Repository navigation
feat: send objective with Alexandria session feedback - #469
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 5/5
- In
tests/mcp-smoke.test.mjs, the short, already-trimmed input won’t catch regressions in trimming or the 2,000-character limit; add padded-input and 2,001-character cases that assert the forwarded value.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/mcp-smoke.test.mjs">
<violation number="1" location="tests/mcp-smoke.test.mjs:1813">
P3: This only exercises a short, already-trimmed value, so it will not catch regressions in the trimming or 2,000-character limit. Add cases for padded input and a 2,001-character objective, asserting the forwarded value is trimmed and the oversized value is rejected.</violation>
</file>
Requires human review: Adds a required objective field to Alexandria session feedback and updates docs/tests. This changes the public tool contract for existing callers and depends on backend deployment #4877, so release coordination and compatibility sign-off are needed.
Fix all with cubic | Re-trigger cubic
| const sessionFeedback = { | ||
| endpoint: 'alexandria', rating: 'partial', | ||
| requestedWebsite: { url: 'https://example.com', requestedFunctionality: 'Download attachments' }, | ||
| objective: 'Compare contract requirements across agencies', |
Contributor
There was a problem hiding this comment.
P3: This only exercises a short, already-trimmed value, so it will not catch regressions in the trimming or 2,000-character limit. Add cases for padded input and a 2,001-character objective, asserting the forwarded value is trimmed and the oversized value is rejected.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At tests/mcp-smoke.test.mjs, line 1813:
<comment>This only exercises a short, already-trimmed value, so it will not catch regressions in the trimming or 2,000-character limit. Add cases for padded input and a 2,001-character objective, asserting the forwarded value is trimmed and the oversized value is rejected.</comment>
<file context>
@@ -1810,6 +1810,7 @@ test('stdio transport calls Firecrawl API through a tool end to end', async (t)
const sessionFeedback = {
endpoint: 'alexandria', rating: 'partial',
requestedWebsite: { url: 'https://example.com', requestedFunctionality: 'Download attachments' },
+ objective: 'Compare contract requirements across agencies',
rationale: 'Only summaries available',
capabilityFeedback: [{ name: 'attachments', provider: 'example', issue: 'new_capability_request', why: 'Missing attachments', requestedFunctionality: 'Return document links' }],
</file context>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl_feedbackwithendpoint: "alexandria"now requires anobjective: the underlying goal behind the session, meaning what the agent or its user was ultimately trying to accomplish, beyond the single website inrequestedWebsite.objectiveis added to the shared Alexandria fields and required in the session schema (trimmed, 1–2000 characters). It is rejected for job feedback, like the other Alexandria-only fields.requestedFunctionality.feedbackToolhint attached to Alexandria results includes anobjectiveplaceholder. It is kept short so oversized-result handoffs stay under the 2,000-character budget.Depends on
Tests
npm test: 164/164 pass. The smoke test sendsobjectiveand rejects missing or blank values. The hint test asserts the placeholder is present.Made with Cursor
Summary by cubic
Adds a required
objectivefield to Alexandria session feedback so sessions record the underlying goal behind the task, and bumps the version to 3.27.1.firecrawl_feedbackwithendpoint: "alexandria"now requiresobjective(trimmed, 1–2000 characters), included in the session schema but rejected for job feedback.objectivediffers fromrequestedFunctionality, and thefeedbackToolhint includes anobjectiveplaceholder.firecrawl-mcpandgemini-extension.jsonto version 3.27.1.Migration
Depends on firecrawl/firecrawl#4877 being deployed first; the API rejects unknown keys in Alexandria feedback until then.
Written for commit a2cfe54. Summary will update on new commits.