fix: drop Node.js SDK from the homepage hero kicker#20
Merged
Conversation
The rest of the hero (terminal demo, Node.js 20+ badge) stays Node-specific on purpose — it's an accurate demo of the flagship product. But the kicker is the very first thing anyone reads, and "LaunchDarkly Node.js SDK → OpenFeature" read as excluding the Go audience before they even reach the "Using Go? Try flaglint-go" CTA two lines down. Dropping "Node.js SDK" keeps the kicker accurate without that first impression. Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified the hero section kicker text on the homepage to remove the "Node.js SDK" qualifier, simplifying the label from "LaunchDarkly Node.js SDK → OpenFeature" to "LaunchDarkly → OpenFeature". ChangesHero Section Text Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying flaglint with
|
| Latest commit: |
daca57e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f8b9cfb.flaglint.pages.dev |
| Branch Preview URL: | https://homepage-kicker-language-agn.flaglint.pages.dev |
flaglint
pushed a commit
that referenced
this pull request
Jul 8, 2026
…trict-types and baseline counts Every identity-resolution gap listed as "not resolved yet" on the flaglint-go Limitations and Supported Scope pages has actually been closed (verified directly against the flaglint-go issue tracker): chained factory-call-then-method (#20), method values (#6), interface satisfaction (#15), block-scoped shadowing (#5), factory returning a wrapper type (#16), and nested go.mod files (#17). These pages were last updated right before that work landed. - limitations.md / supported-scope.md: mark all six as resolved (noting which layer resolves each — Phase 1 default vs. opt-in --strict-types), add two newer Phase-1 mechanisms these pages never mentioned at all (a struct field declared *ld.LDClient with no observed construction, and a composite literal directly initializing a package-level var), and state plainly that zero identity-resolution gaps are currently tracked. - identity-model.md: add worked examples for both newer Phase-1 mechanisms above, plus a new "Phase 2 — --strict-types" section (interface satisfaction, transitive factory wrapping, cross-function method-value forwarding) that didn't exist on this page at all before. - index.md: same corrections to the "what flaglint-go does/doesn't do" summary — it previously named method values and interface satisfaction as open gaps. - cli/{scan,audit,validate}.md: --strict-types wasn't documented as a flag anywhere on the site despite being available on all three commands since it shipped; added to each page's options table. audit.md's baseline JSON example was also missing the "schemaVersion" and "counts" fields flaglint-go now emits; validate.md's Baseline Mode section gains a note on what "counts" actually catches (a brand-new duplicate of an already-baselined call, not just a brand-new fingerprint). Verified: `npm run build` completes cleanly (90 pages), spot-checked the rendered Limitations page's output directly. Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line tweak:
LaunchDarkly Node.js SDK → OpenFeature→LaunchDarkly → OpenFeature.The rest of the hero (terminal demo, "Node.js 20+" badge) stays Node-specific on purpose — accurate demo of the flagship product. But the kicker is the first thing anyone reads, and calling out "Node.js SDK" specifically read as excluding the Go audience before they even reach the "Using Go? Try flaglint-go" CTA two lines down.
Test plan
npm run build— cleanSummary by CodeRabbit