Crossplane KMS

[ivan-flamingo]

No description provided.

[github-actions]

🦩 Flamingo Code Review

1 finding(s) — 1 action required · 0 recommended · 0 informational

Mode: advisory · 1 defect(s) outside any rule

Inline comments: 1 new

---

Need another pass? Commits pushed after this review are not reviewed automatically.

• Review the new commits — the commits added since this review
• Review the whole diff again — ignoring what was already reviewed

Prefer typing? Comment @flamingo-review, or @flamingo-review full. To review every push on this pull request, add the flamingo-review-always label.

React 👍/👎 on inline comments to teach the reviewer.

Started 2026-09-16 07:55 UTC · updated 2026-09-16 07:56 UTC · workflow run

[github-actions]

🦩 🔴 [error/action_required] Crossplane/GCP provider sync block duplicated wholesale, creating duplicate regsync entries

The diff appends an entirely new '# Infrastructure as Code / Crossplane control plane...' section (lines 543-574 in the working tree, corresponding to the added hunk) that duplicates the crossplane, provider-family-gcp, and provider-gcp-cloudplatform entries already present a few lines above (lines 498-523). This means regsync-config.yaml now has two separate sync entries for xpkg.crossplane.io/crossplane/crossplane, two for provider-family-gcp, and two for provider-gcp-cloudplatform, all with identical source/target/semverRange/allow values. regsync will likely fail or behave unpredictably with duplicate sync entries for the same source/target pair (undefined behavior on conflicting duplicate rules, or simply wasted duplicate sync work). This looks like a bad merge/rebase artifact where the new provider-gcp-kms entry was intended to be added to the existing block, but instead the whole block got duplicated. The duplicate block (and its section header comment) should be removed, keeping only the single block with provider-gcp-kms added into the original section.

Evidence

  # ---------------------------------------------------------------------------
  # Infrastructure as Code
  # Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
  # Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform
  # ---------------------------------------------------------------------------

  - source: xpkg.crossplane.io/crossplane/crossplane
    target: ${TARGET_REGISTRY}/crossplane/crossplane
    type: repository
    tags:
      semverRange:
        - ">=2.3.5"

🤖 Prompt for AI agents

In regsync-config.yaml around lines 543-574, address this code-review finding: Crossplane/GCP provider sync block duplicated wholesale, creating duplicate regsync entries.
The diff appends an entirely new '# Infrastructure as Code / Crossplane control plane...' section (lines 543-574 in the working tree, corresponding to the added hunk) that duplicates the crossplane, provider-family-gcp, and provider-gcp-cloudplatform entries already present a few lines above (lines 498-523). This means regsync-config.yaml now has two separate sync entries for xpkg.crossplane.io/crossplane/crossplane, two for provider-family-gcp, and two for provider-gcp-cloudplatform, all with identical source/target/semverRange/allow values. regsync will likely fail or behave unpredictably with duplicate sync entries for the same source/target pair (undefined behavior on conflicting duplicate rules, or simply wasted duplicate sync work). This looks like a bad merge/rebase artifact where the new provider-gcp-kms entry was intended to be added to the existing block, but instead the whole block got duplicated. The duplicate block (and its section header comment) should be removed, keeping only the single block with provider-gcp-kms added into the original section.
The flagged code:
```
  # ---------------------------------------------------------------------------
  # Infrastructure as Code
  # Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
  # Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform
  # ---------------------------------------------------------------------------

  - source: xpkg.crossplane.io/crossplane/crossplane
    target: ${TARGET_REGISTRY}/crossplane/crossplane
    type: repository
    tags:
      semverRange:
        - ">=2.3.5"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'

  - source: xpkg.upbound.io/upbound/provider-family-gcp
    target: ${TARGET_REGISTRY}/upbound/provider-family-gcp
    type: repository
    tags:
      semverRange:
        - ">=3.0.0"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'

  - source: xpkg.upbound.io/upbound/provider-gcp-cloudplatform
    target: ${TARGET_REGISTRY}/upbound/provider-gcp-cloudplatform
    type: repository
    tags:
      semverRange:
        - ">=3.0.0"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'
```
Make the minimal change that resolves the finding; do not refactor unrelated code.

confidence: 92 — react 👍/👎 to teach the reviewer