Skip to content

Crossplane KMS #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-flamingo merged 3 commits into from
Sep 16, 2026
+43 −1
Merged

Crossplane KMS #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cffdbc
Crossplane Image
ivan-flamingo Sep 10, 2026
f9e1bcb
Crossplane kms.gcp
ivan-flamingo Sep 16, 2026
909ab8d
Merge branch 'main' into hotfix/aak
ivan-flamingo Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion regsync-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ sync:
# ---------------------------------------------------------------------------
# Infrastructure as Code
# Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
# Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform, provider-gcp-storage
# Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform, provider-gcp-kms, provider-gcp-storage
# ---------------------------------------------------------------------------

- source: xpkg.crossplane.io/crossplane/crossplane
Expand Down Expand Up @@ -522,6 +522,15 @@ sync:
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'

- source: xpkg.upbound.io/upbound/provider-gcp-kms
target: ${TARGET_REGISTRY}/upbound/provider-gcp-kms
type: repository
tags:
semverRange:
- ">=3.0.0"
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'

- source: xpkg.upbound.io/upbound/provider-gcp-storage
target: ${TARGET_REGISTRY}/upbound/provider-gcp-storage
type: repository
Expand All @@ -531,6 +540,39 @@ sync:
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'

# ---------------------------------------------------------------------------
# Infrastructure as Code
# Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
# Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform
# ---------------------------------------------------------------------------

- source: xpkg.crossplane.io/crossplane/crossplane
target: ${TARGET_REGISTRY}/crossplane/crossplane
type: repository
tags:
semverRange:
- ">=2.3.5"
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'

- source: xpkg.upbound.io/upbound/provider-family-gcp
target: ${TARGET_REGISTRY}/upbound/provider-family-gcp
type: repository
tags:
semverRange:
- ">=3.0.0"
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'

- source: xpkg.upbound.io/upbound/provider-gcp-cloudplatform
target: ${TARGET_REGISTRY}/upbound/provider-gcp-cloudplatform
type: repository
tags:
semverRange:
- ">=3.0.0"
allow:
- 'v[0-9]+\.[0-9]+\.[0-9]+'
Comment on lines +543 to +574

@github-actions github-actions Bot Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 [error/action_required] Crossplane/GCP provider sync block duplicated wholesale, creating duplicate regsync entries

The diff appends an entirely new '# Infrastructure as Code / Crossplane control plane...' section (lines 543-574 in the working tree, corresponding to the added hunk) that duplicates the crossplane, provider-family-gcp, and provider-gcp-cloudplatform entries already present a few lines above (lines 498-523). This means regsync-config.yaml now has two separate sync entries for xpkg.crossplane.io/crossplane/crossplane, two for provider-family-gcp, and two for provider-gcp-cloudplatform, all with identical source/target/semverRange/allow values. regsync will likely fail or behave unpredictably with duplicate sync entries for the same source/target pair (undefined behavior on conflicting duplicate rules, or simply wasted duplicate sync work). This looks like a bad merge/rebase artifact where the new provider-gcp-kms entry was intended to be added to the existing block, but instead the whole block got duplicated. The duplicate block (and its section header comment) should be removed, keeping only the single block with provider-gcp-kms added into the original section.

Evidence 
  # ---------------------------------------------------------------------------
  # Infrastructure as Code
  # Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
  # Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform
  # ---------------------------------------------------------------------------

  - source: xpkg.crossplane.io/crossplane/crossplane
    target: ${TARGET_REGISTRY}/crossplane/crossplane
    type: repository
    tags:
      semverRange:
        - ">=2.3.5"
🤖 Prompt for AI agents 
In regsync-config.yaml around lines 543-574, address this code-review finding: Crossplane/GCP provider sync block duplicated wholesale, creating duplicate regsync entries.
The diff appends an entirely new '# Infrastructure as Code / Crossplane control plane...' section (lines 543-574 in the working tree, corresponding to the added hunk) that duplicates the crossplane, provider-family-gcp, and provider-gcp-cloudplatform entries already present a few lines above (lines 498-523). This means regsync-config.yaml now has two separate sync entries for xpkg.crossplane.io/crossplane/crossplane, two for provider-family-gcp, and two for provider-gcp-cloudplatform, all with identical source/target/semverRange/allow values. regsync will likely fail or behave unpredictably with duplicate sync entries for the same source/target pair (undefined behavior on conflicting duplicate rules, or simply wasted duplicate sync work). This looks like a bad merge/rebase artifact where the new provider-gcp-kms entry was intended to be added to the existing block, but instead the whole block got duplicated. The duplicate block (and its section header comment) should be removed, keeping only the single block with provider-gcp-kms added into the original section.
The flagged code:
```
  # ---------------------------------------------------------------------------
  # Infrastructure as Code
  # Crossplane control plane and its GCP provider packages (OCI xpkg artifacts)
  # Includes: Crossplane, provider-family-gcp, provider-gcp-cloudplatform
  # ---------------------------------------------------------------------------

  - source: xpkg.crossplane.io/crossplane/crossplane
    target: ${TARGET_REGISTRY}/crossplane/crossplane
    type: repository
    tags:
      semverRange:
        - ">=2.3.5"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'

  - source: xpkg.upbound.io/upbound/provider-family-gcp
    target: ${TARGET_REGISTRY}/upbound/provider-family-gcp
    type: repository
    tags:
      semverRange:
        - ">=3.0.0"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'

  - source: xpkg.upbound.io/upbound/provider-gcp-cloudplatform
    target: ${TARGET_REGISTRY}/upbound/provider-gcp-cloudplatform
    type: repository
    tags:
      semverRange:
        - ">=3.0.0"
      allow:
        - 'v[0-9]+\.[0-9]+\.[0-9]+'
```
Make the minimal change that resolves the finding; do not refactor unrelated code.

confidence: 92 — react 👍/👎 to teach the reviewer


# ---------------------------------------------------------------------------
# Kubernetes Infrastructure
# Core K8s components for certificates, ingress, DNS, and cluster management
Expand Down