system_config: add path attribute in system/log section - #516
Merged
Conversation
Contributor
|
Thanks! It appears that we need to fix other areas. For example: https://docs.fluentd.org/deployment/logging#output-to-log-file It would be a bit difficult for users to understand this feature because it can also be set by command line options. |
Contributor
Author
|
Thank you for your review. OK, I will add more content in Logging page. |
Watson1978
force-pushed
the
system_config/log/path
branch
from
September 26, 2024 23:59
aac3765 to
fe26fff
Compare
Contributor
Author
|
I added the description in logging page. |
daipom
reviewed
Sep 27, 2024
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
I have commented on some points. Please check them!
This feature was introduced at fluent/fluentd#4604 Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
system_config/log/path
branch
from
September 27, 2024 01:56
2496019 to
1d7ab8d
Compare
Contributor
|
Merge when v1.18 was released. |
Contributor
|
Thanks for this update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was introduced at fluent/fluentd#4604