Skip to content

system_config: add path attribute in system/log section - #4604

Merged
daipom merged 1 commit into
fluent:masterfrom
Watson1978:log_path
Sep 24, 2024
Merged

system_config: add path attribute in system/log section#4604
daipom merged 1 commit into
fluent:masterfrom
Watson1978:log_path

Conversation

@Watson1978

@Watson1978 Watson1978 commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:
Fixes #4418

What this PR does / why we need it:
This patch will add path attribute in sytem/log section due to configure log file path by System Configuration.

Docs Changes:
fluent/fluentd-docs-gitbook#516

Release Note:
The same as the title.

@Watson1978 Watson1978 changed the title sytem_config: add log_path attribute in system section system_config: add log_path attribute in system section Aug 19, 2024
@Watson1978
Watson1978 marked this pull request as ready for review August 19, 2024 08:10
@Watson1978
Watson1978 marked this pull request as draft August 19, 2024 08:12
@Watson1978 Watson1978 changed the title system_config: add log_path attribute in system section system_config: add path attribute in system/log section Aug 19, 2024
This patch will add `path` attribute in sytem/log section due to configure log file path  by System Configuration.

Signed-off-by: Watson <watson1978@gmail.com>
@Watson1978
Watson1978 marked this pull request as ready for review August 19, 2024 08:56

@ashie ashie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashie
ashie requested a review from daipom August 20, 2024 00:56

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom

daipom commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

@Watson1978 If you have time, it would be great if you could update the document.

@Watson1978
Watson1978 deleted the log_path branch September 24, 2024 12:54
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 25, 2024
This feature was introduced at fluent/fluentd#4604
Signed-off-by: Watson <watson1978@gmail.com>
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 25, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 26, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 27, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set log_path in system config

3 participants