Fixes for Ruby 3.4-dev - #4411
Merged
Merged
Conversation
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
base64, csv and drb gems aren't part of the default gems since Ruby 3.4.0. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
This was referenced Feb 28, 2024
ashie
marked this pull request as ready for review
March 6, 2024 03:07
Watson1978
added a commit
to Watson1978/fluentd
that referenced
this pull request
Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5. Therefore, it will not work on Ruby 3.5 unless it is added as a dependency. Ref. ruby/ruby@d7e558e (Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.) Similar with fluentGH-4411 Signed-off-by: Watson <watson1978@gmail.com>
daipom
pushed a commit
that referenced
this pull request
Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5. Therefore, it will not work on Ruby 3.5 unless it is added as a dependency. Ref. ruby/ruby@d7e558e (Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.) Similar with GH-4411 Signed-off-by: Watson <watson1978@gmail.com>
Contributor
|
Without this patch, it seems impossible to test the v1.16 branch with ruby 3.4 or later... |
Watson1978
added
the
backport to v1.16
kenhys
pushed a commit
that referenced
this pull request
Dec 5, 2025
Backport #4411 **Which issue(s) this PR fixes**: N/A **What this PR does / why we need it**: CI is failed on Ruby 3.4-dev: https://github.com/fluent/fluentd/actions/runs/7949585800 **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Takuro Ashie <ashie@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Co-authored-by: Takuro Ashie <ashie@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
CI is failed on Ruby 3.4-dev:
https://github.com/fluent/fluentd/actions/runs/7949585800
Docs Changes:
N/A
Release Note:
N/A