tests: fix unused_port - #4675
Merged
Merged
Conversation
It obtains unused port number for TCP by unused_port method and the number has been used in UDP. And that number may be already used by UDP sockets. This patch will obtain and use unused ports appropriately for each protocol. Signed-off-by: Watson <fujita@clear-code.com>
ashie
approved these changes
Oct 21, 2024
Member
|
Thanks! |
Merged
kenhys
pushed a commit
that referenced
this pull request
Jan 28, 2025
It obtains unused port number for TCP by unused_port method and the number has been used in UDP. And that number may be already used by UDP sockets. This patch will obtain and use unused ports appropriately for each protocol. See #4675 Signed-off-by: Watson <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
**Which issue(s) this PR fixes**: Fixes #4674 **What this PR does / why we need it**: It obtains unused port number for TCP by unused_port method and the number has been used in UDP. And that number may be already used by UDP sockets. This patch will obtain and use unused ports appropriately for each protocol. Backported from #4675 **Docs Changes**: **Release Note**: Signed-off-by: Watson <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Watson <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4674
What this PR does / why we need it:
It obtains unused port number for TCP by
unused_portmethod and the number has been used in UDP.And that number may be already used by UDP sockets.
This patch will obtain and use unused ports appropriately for each protocol.
Docs Changes:
Release Note: