tantivy 0.22 → 0.26 with graceful FTS reset (lru advisory path) - #253
Merged
Merged
Conversation
- TopDocs::with_limit now needs .order_by_score() (collector API change), applied at the three search call sites - tantivy cannot open index files written by an older major; an unreadable FTS index is now wiped + recreated instead of failing the DB open. FTS is derived data: BM25 rebuilds on next (re)index, vector search unaffected. Warning logged. Regression test: corrupt meta.json. - merged origin/develop (fastembed 6 CHANGELOG repair + entries) Validation: fmt, clippy -D warnings, cargo test --lib --bins green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fase D2 of the dependency roadmap.
Code changes (small)
TopDocs::with_limit(n)→.order_by_score()at the three search call sites (collector API change in 0.26)Behavior: unreadable FTS index resets instead of bricking the DB
tantivy cannot open index files written by an older major. Pre-upgrade DBs would have failed
FtsStore::newon every path (search, serve, doctor). The FTS index is derived data, so an unreadable index is now wiped and recreated empty with a warning pointing atcodesearch index; BM25 rebuilds on the next (re)index. Vector search and all non-FTS paths unaffected. Pinned by a regression test (corruptmeta.json→ store opens, searches empty, accepts writes).Advisory impact
lru 0.12.5 (via tantivy) is gone — tantivy 0.26 uses lru 0.16.4. The lru 0.12.5 residue still via ratatui 0.29 clears with the ratatui 0.30 bump (follow-up).
Validation
fmt, clippy -D warnings, cargo test --lib --bins: 1386 passed / 0 failed.