Skip to content

Retain outgoing-edge range dependencies through Tick history - #917

Merged
flyingrobots merged 5 commits into
mainfrom
feat/derived-effect-validation
Oct 19, 2026
Merged

flyingrobots merged 5 commits into
mainfrom
feat/derived-effect-validation

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Preserve outgoing-edge range dependencies through scheduling, retained patches, provenance, witness encodings and admission. A declared empty range now conflicts with insertion into that source/type range, and the rejected Action records its exact blocker. Full WARP/source/type keys participate in footprint and patch identities. Existing point-slot bytes and footprints without range claims retain their previous identity streams; old decoders reject the additive range slot tag.

Historical host readings reconstruct aggregate ranges across insertions, relabels, moves and deletions, including empty versus absent source. They clone the initial state and replay the selected prefix. The storage iterator exposes its remaining bucket length without inspecting edges, allowing future bounded readers to precharge the entire bucket.

Validation: 843 default core tests before the additional bucket witness; 18 feature-enabled range tests; 7 public retained-provenance integration tests including receipt-bound commit-v3 and tamper refusal; both graph-store unit tests; workspace all-target compilation; strict all-target Clippy with native_rule_bootstrap,trusted_runtime,host_test,delta_validate,footprint_enforce_release and warnings denied. Tests first exposed missing conflicts, identity claims, aggregate reads, admission projection and Tick blocker reconstruction.

This is a completed infrastructure slice for the authored effect bridge. Claims remain explicit. Existing graph accessors and edge writers are not automatically instrumented, and source presence needs a separate node dependency. No Edict program gains graph mutation authority. Automatic witnessed reads, complete effect write claims, exact-parent effect validation and fresh-engine recovery remain required follow-up work under #889. Its designated writer retains ownership of the provisional design and acceptance language.

Canonical scheduler, tick-patch and generated-rule documents and the changelog describe the behavior and limits. No dependencies or application vocabulary are introduced.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: flyingrobots/echo/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 95df7007-7549-47ae-befe-fff4dc85c41d
📥 Commits

Reviewing files that changed from the base of the PR and between b314f7f and d556ad3.

📒 Files selected for processing: 31
  • CHANGELOG.md
  • crates/echo-dry-tests/src/demo_rules.rs
  • crates/echo-dry-tests/src/footprint.rs
  • crates/warp-core/src/admission.rs
  • crates/warp-core/src/cmd.rs
  • crates/warp-core/src/contract_host.rs
  • crates/warp-core/src/echo_operation.rs
  • crates/warp-core/src/engine_impl.rs
  • crates/warp-core/src/engine_impl/range_tests.rs
  • crates/warp-core/src/footprint.rs
  • crates/warp-core/src/footprint/range_tests.rs
  • crates/warp-core/src/graph.rs
  • crates/warp-core/src/inbox.rs
  • crates/warp-core/src/lib.rs
  • crates/warp-core/src/observation.rs
  • crates/warp-core/src/provenance_codec.rs
  • crates/warp-core/src/provenance_codec/range_tests.rs
  • crates/warp-core/src/scheduler.rs
  • crates/warp-core/src/scheduler/range_tests.rs
  • crates/warp-core/src/settlement.rs
  • crates/warp-core/src/slot_reading.rs
  • crates/warp-core/src/slot_reading/range_tests.rs
  • crates/warp-core/src/tick_patch.rs
  • crates/warp-core/src/witnessed_suffix.rs
  • crates/warp-core/tests/common/mod.rs
  • crates/warp-core/tests/parallel_footprints.rs
  • crates/warp-core/tests/provenance_retention_codec_tests.rs
  • crates/warp-core/tests/slice_theorem_proof.rs
  • docs/spec/scheduler-warp-core.md
  • docs/spec/warp-tick-patch.md
  • docs/topics/GeneratedRules.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flyingrobots flyingrobots changed the title Preserve outgoing-edge range dependencies through execution Retain outgoing-edge range dependencies through Tick history Oct 19, 2026
@flyingrobots
flyingrobots marked this pull request as ready for review October 19, 2026 05:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T05:06:21.413807Z d556ad3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@flyingrobots
flyingrobots merged commit 4e801ef into main Oct 19, 2026
44 checks passed
@flyingrobots
flyingrobots deleted the feat/derived-effect-validation branch October 19, 2026 05:08
flyingrobots added a commit that referenced this pull request Oct 20, 2026
Brings the branch up to main 4e801ef+ (including #917's outgoing-edge
range dependencies) so the design's citations describe this tree.

CHANGELOG: main's Unreleased again carried a second Added and Fixed
subsection (markdownlint MD024). Their entries are folded into the
existing Added and Fixed subsections; sorted content is unchanged apart
from the two removed headings and their blank lines. The pre-commit hook
also applied prettier to five Markdown files from main that were not
formatted.
flyingrobots added a commit that referenced this pull request Oct 20, 2026
The Current implementation section, the range-read rationale, and the recovery reconstruction text still said Footprint had no range key. Since #917 it has OutgoingEdgeRange claims (r_read, r_write) in footprint and patch identities, retained through scheduling, provenance, and admission. The text now says so and states what remains: claims are declared rather than witnessed, no accessor or edge writer records them, source presence needs its own node dependency, and witnessed reads, complete effect write claims, exact-parent validation, and fresh-engine recovery are still to be built.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant