Repository navigation
chore/code rabbit cleanup - #172
Merged
Merged
Conversation
The core logic is refactored to minimize direct dependency on the libgit2 API for OID (SHA) handling and blob resolution. OID utilities are now internal and shared, improving encapsulation and maintainability. This is a continuation of the dependency reduction effort, moving logic out of `core/src/cache/query.c` and into shared utility files. 1. **Extract Shared Blob Resolution:** The duplicated `resolve_blob_identity` logic from `core/src/edge/edge.c` and `core/src/edge/attributed.c` is extracted into a new shared helper `gm_edge_resolve_blob_identity` in `core/src/edge/internal/blob_identity.c`. 2. **Introduce OID Utility:** New internal functions `gm_bytes_to_hex` and `gm_oid_to_hex` are created in `core/src/util/oid.c`. 3. **Decouple Cache/Query:** Cache query and rebuild services now use the new `gm_oid_to_hex` utility, allowing the removal of remaining direct `libgit2/oid.h` dependencies from `core/src/cache/query.c` and `core/src/app/cache/cache_rebuild_service.c`. 4. **Path Utility Hardening:** Added explicit bounds checking for segment arrays and ensured output buffers are zeroed on failure paths in `core/src/fs/path_utils.c`. 5. **Metadata Alignment:** Aligned the `gm_cache_meta_t` members to ensure `journal_tip_oid_bin` is not at the end of the struct, though the member comment states it is *preferred* over the string version, hinting at a future migration path.
Contributor
WalkthroughAdds OID hex utilities and a blob-identity resolver, integrates them into edge/cache/query flows, hardens filesystem path parsing and fake-port safety, updates Meson sources, adjusts worksheet/CI tooling and review artifacts, and introduces scripts/workflows for CodeRabbit status and review-artifact cleanup. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor EdgeCreator as Edge Creator
participant BI as gm_edge_resolve_blob_identity
participant Port as Git Repository Port
EdgeCreator->>BI: resolve_blob_identity(ctx, path, out_oid, legacy_sha)
BI->>Port: gm_git_repository_port_resolve_blob_at_head(path)
Port-->>BI: oid_bytes / error
alt port success
BI->>BI: copy min(GM_OID_RAWSZ, GM_SHA1_SIZE) → legacy_sha
BI->>BI: zero-pad remainder if copy_len < GM_SHA1_SIZE
BI-->>EdgeCreator: GM_OK (out_oid, legacy_sha)
else port error
BI->>BI: zero legacy_sha
BI-->>EdgeCreator: error (propagate)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
core/src/cache/query.c (1)
211-214: Fix time underflow in staleness check.(now - meta.journal_tip_time) can underflow when clocks skew backwards, falsely marking as stale.
Apply this diff:
- time_t now = time(NULL); - if ((uint64_t)now - meta.journal_tip_time > CACHE_MAX_AGE_SECONDS) { + time_t now = time(NULL); + uint64_t age = 0; + if ((uint64_t)now >= meta.journal_tip_time) { + age = (uint64_t)now - meta.journal_tip_time; + } else { + age = 0; /* treat as fresh if journal time is in the future */ + } + if (age > CACHE_MAX_AGE_SECONDS) { return true; }core/src/edge/attributed.c (1)
293-295: Remove NOLINT and address easily-swappable parameters properly.Repo guideline forbids NOLINT in C/C++. Replace with a parameter object/wrapper to avoid two adjacent const char*.
Apply this minimal diff now:
- // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)Follow-up (separate PR acceptable):
- Introduce
typedef struct { const char *src_path; const char *tgt_path; } gm_edge_paths_t;- Add
gm_edge_attributed_create_ex(gm_context_t*, gm_edge_paths_t, gm_rel_type_t, uint16_t, const gm_attribution_t*, gm_lane_type_t)and migrate call sites; keep current API temporarily as thin wrapper.
🧹 Nitpick comments (6)
core/src/cache/query.c (3)
75-97: Harden get_sha_prefix: accept buffer size, validate inputs, avoid hidden coupling.
- Current impl assumes SHA_PREFIX_BUFFER_SIZE and doesn’t validate sha/prefix; propagate errors instead of silently emptying.
- Prefer returning status and taking prefix_size to satisfy “zero output buffers on error paths” guideline.
Apply this diff:
-/* Get SHA prefix for sharding */ -static void get_sha_prefix(const uint8_t *sha, char *prefix, int bits) { +/* Get OID prefix for sharding */ +static int gm_get_oid_prefix(const uint8_t *sha, char *prefix, size_t prefix_size, int bits) { - int chars = (bits + 3) / BITS_PER_HEX_CHAR; /* Round up to hex chars */ - if (chars <= 0) { - prefix[0] = '\0'; - return; - } + if (!sha || !prefix || prefix_size == 0) return GM_ERR_INVALID_ARGUMENT; + gm_memset_safe(prefix, prefix_size, 0, prefix_size); + int chars = (bits + 3) / BITS_PER_HEX_CHAR; /* Round up to hex chars */ + if (chars <= 0) return GM_OK; - char hex[GM_OID_HEX_CHARS + 1] = {0}; - if (gm_bytes_to_hex(sha, GM_OID_RAWSZ, hex, sizeof(hex)) != GM_OK) { - prefix[0] = '\0'; - return; - } + char hex[GM_OID_HEX_CHARS + 1] = {0}; + int rc = gm_bytes_to_hex(sha, GM_OID_RAWSZ, hex, sizeof(hex)); + if (rc != GM_OK) return rc; if (chars > GM_OID_HEX_CHARS) { chars = GM_OID_HEX_CHARS; } - if (chars >= SHA_PREFIX_BUFFER_SIZE) { - chars = SHA_PREFIX_BUFFER_SIZE - 1; - } - for (int i = 0; i < chars; ++i) { - prefix[i] = hex[i]; - } - prefix[chars] = '\0'; + if ((size_t)chars >= prefix_size) { + chars = (int)prefix_size - 1; + } + gm_memcpy_span(prefix, prefix_size, hex, (size_t)chars); + prefix[chars] = '\0'; + return GM_OK; }And update the sole call site (see below).
254-271: Return exact error and align names with OID terminology.
- Use GM_OID_HEX_CHARS + 1 for buffer size (avoid SHA_HEX_SIZE).
- Propagate gm_bytes_to_hex’s rc instead of hard‑coding BUFFER_TOO_SMALL.
Apply this diff:
- char prefix[SHA_PREFIX_BUFFER_SIZE]; - char sha_hex[SHA_HEX_SIZE]; + char prefix[SHA_PREFIX_BUFFER_SIZE]; + char sha_hex[GM_OID_HEX_CHARS + 1]; char path[CACHE_PATH_BUFFER_SIZE]; int rc; /* Get shard prefix */ - get_sha_prefix(sha, prefix, GM_CACHE_SHARD_BITS); + rc = gm_get_oid_prefix(sha, prefix, sizeof(prefix), GM_CACHE_SHARD_BITS); + if (rc != GM_OK) return rc; /* Convert SHA to hex */ - if (gm_bytes_to_hex(sha, GM_OID_RAWSZ, sha_hex, sizeof(sha_hex)) != GM_OK) { - return GM_ERR_BUFFER_TOO_SMALL; - } + rc = gm_bytes_to_hex(sha, GM_OID_RAWSZ, sha_hex, sizeof(sha_hex)); + if (rc != GM_OK) return rc;Based on learnings.
254-256: Migrate SHA_ hex buffers to OID_ naming**
- In core/src/cache/query.c (L27–28, L254–256) and core/src/app/cache/cache_rebuild_service.c (L188–190):
• RemoveSHA_HEX_SIZEandsha_hex[]; replace withchar oid_hex[GM_OID_HEX_CHARS + 1]and rename all uses ofsha_hextooid_hex.
• Define and use anOID_PREFIX_BUFFER_SIZE(in place ofSHA_PREFIX_BUFFER_SIZE) for yourprefixbuffers.
• Update calls togm_bytes_to_hex/oid_to_hexandgm_snprintfto useoid_hex.core/src/app/cache/cache_rebuild_service.c (2)
116-137: Make get_oid_prefix robust and reusable.Mirror the query-side fix: take buffer size, return status, zero buffer on errors. Reduces hidden coupling to MAX_SHARD_PATH and improves error signaling.
Apply this diff:
-static void get_oid_prefix(const gm_oid_t *oid, char *prefix, int bits) { +static int gm_get_oid_prefix_from_oid(const gm_oid_t *oid, char *prefix, size_t prefix_size, int bits) { int chars = (bits + 3) / BITS_PER_HEX_CHAR; /* Round up to hex chars */ if (chars <= 0) { - prefix[0] = '\0'; - return; + if (prefix && prefix_size) gm_memset_safe(prefix, prefix_size, 0, prefix_size); + return GM_OK; } - char hex[GM_OID_HEX_CHARS + 1] = {0}; - if (gm_oid_to_hex(oid, hex, sizeof(hex)) != GM_OK) { - prefix[0] = '\0'; - return; - } + char hex[GM_OID_HEX_CHARS + 1] = {0}; + int rc = gm_oid_to_hex(oid, hex, sizeof(hex)); + if (rc != GM_OK) { + if (prefix && prefix_size) gm_memset_safe(prefix, prefix_size, 0, prefix_size); + return rc; + } if (chars > GM_OID_HEX_CHARS) { chars = GM_OID_HEX_CHARS; } - int limit = (chars < (MAX_SHARD_PATH - 1)) ? chars : (MAX_SHARD_PATH - 1); + if (!prefix || prefix_size == 0) return GM_ERR_INVALID_ARGUMENT; + int limit = (chars < ((int)prefix_size - 1)) ? chars : ((int)prefix_size - 1); for (int index = 0; index < limit; ++index) { prefix[index] = hex[index]; } prefix[limit] = '\0'; + return GM_OK; }Follow-up: update the single call site at Line 182 to pass sizeof(prefix) and handle rc.
188-193: Align naming and sizing: use OID hex terminology.Rename
sha_hextooid_hexand size by GM_OID_HEX_CHARS + 1 to avoid assumptions tied to legacy SHA-1.Apply this diff:
- char sha_hex[SHA_HEX_SIZE]; - int hex_status = oid_to_hex(oid, sha_hex, sizeof(sha_hex)); + char oid_hex[GM_OID_HEX_CHARS + 1]; + int hex_status = oid_to_hex(oid, oid_hex, sizeof(oid_hex)); if (hex_status != GM_OK) { return hex_status; } - if (gm_snprintf(path, sizeof(path), "%s/%s/%s.%s", ctx->temp_dir, prefix, - sha_hex, ctx->suffix) < 0) { + if (gm_snprintf(path, sizeof(path), "%s/%s/%s.%s", ctx->temp_dir, prefix, + oid_hex, ctx->suffix) < 0) { return GM_ERR_UNKNOWN; }Based on learnings
core/src/edge/attributed.c (1)
342-344: Check gm_memcpy_safe return codes (even after prevalidation).Guideline: always check and handle string/memory op return codes; treat truncation as failure.
Apply this diff:
- gm_memcpy_safe(edge.src_path, sizeof edge.src_path, src_path, src_len + 1); - gm_memcpy_safe(edge.tgt_path, sizeof edge.tgt_path, tgt_path, tgt_len + 1); + if (gm_memcpy_safe(edge.src_path, sizeof edge.src_path, src_path, src_len + 1) != GM_OK) + return (gm_result_edge_attributed_t){.ok = false, .u.err = GM_ERROR(GM_ERR_BUFFER_TOO_SMALL, "src_path copy failed")}; + if (gm_memcpy_safe(edge.tgt_path, sizeof edge.tgt_path, tgt_path, tgt_len + 1) != GM_OK) + return (gm_result_edge_attributed_t){.ok = false, .u.err = GM_ERROR(GM_ERR_BUFFER_TOO_SMALL, "tgt_path copy failed")};
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (34)
AGENTS.md(1 hunks)core/include/gitmind/cache.h(1 hunks)core/include/gitmind/edge/internal/blob_identity.h(1 hunks)core/include/gitmind/util/oid.h(1 hunks)core/src/app/cache/cache_rebuild_service.c(3 hunks)core/src/cache/query.c(3 hunks)core/src/edge/attributed.c(2 hunks)core/src/edge/edge.c(2 hunks)core/src/edge/internal/blob_identity.c(1 hunks)core/src/fs/path_utils.c(3 hunks)core/src/util/oid.c(1 hunks)core/tests/fakes/git/fake_git_repository_port.c(2 hunks)docs/code-reviews/CLAUDE.md(0 hunks)docs/code-reviews/PR169/e4f3f906eb454cb103eb8cc6899df8dfbf6e2349.md(0 hunks)docs/code-reviews/PR171/258c9f05de4f483c8c9a039df4b2307bba72ed97.md(0 hunks)docs/code-reviews/PR171/7195186ca1374dcef93a846f882a11ebbc7fb861.md(0 hunks)docs/code-reviews/PR172/203f4e3539b1d8fc73b641e94b0a420f2e592a14.md(1 hunks)docs/code-reviews/rejected-suggestions/1d234c5614f96272eca5e9607d84b3655080546b_feat-cli-safety-e2e_166_valgrind-suppression-link.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_angle-includes.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_consumed-length.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_e2e-refactor.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_markdownlint.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_replace-macros-with-literals.md(0 hunks)docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_umbrella-safety-include.md(0 hunks)docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_md-verify-alias.md(0 hunks)docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_phony-ordering.md(0 hunks)docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_pre-push-changelog-variants.md(0 hunks)docs/code-reviews/rejected-suggestions/608bc03_main_cstd-c23-only.md(0 hunks)docs/code-reviews/rejected-suggestions/608bc03_main_deprec-macros-augment.md(0 hunks)docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR164_detached-head-behavior.md(0 hunks)docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR165_move-test-prototypes-private.md(0 hunks)docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR165_reserve-extra-byte.md(0 hunks)docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR166_missing-umbrella-apis.md(0 hunks)meson.build(2 hunks)
💤 Files with no reviewable changes (20)
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_umbrella-safety-include.md
- docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR164_detached-head-behavior.md
- docs/code-reviews/PR169/e4f3f906eb454cb103eb8cc6899df8dfbf6e2349.md
- docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_md-verify-alias.md
- docs/code-reviews/CLAUDE.md
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_replace-macros-with-literals.md
- docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR165_move-test-prototypes-private.md
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_e2e-refactor.md
- docs/code-reviews/rejected-suggestions/1d234c5614f96272eca5e9607d84b3655080546b_feat-cli-safety-e2e_166_valgrind-suppression-link.md
- docs/code-reviews/PR171/258c9f05de4f483c8c9a039df4b2307bba72ed97.md
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_consumed-length.md
- docs/code-reviews/rejected-suggestions/608bc03_main_cstd-c23-only.md
- docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR165_reserve-extra-byte.md
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_markdownlint.md
- docs/code-reviews/rejected-suggestions/ef52094_migration-finish-core-cleanup_PR166_missing-umbrella-apis.md
- docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_pre-push-changelog-variants.md
- docs/code-reviews/rejected-suggestions/4d28721c4b98c6dd29f475d5a1974c2fd2d95a1a_feat-cli-safety-e2e_166_angle-includes.md
- docs/code-reviews/PR171/7195186ca1374dcef93a846f882a11ebbc7fb861.md
- docs/code-reviews/rejected-suggestions/608bc03_main_deprec-macros-augment.md
- docs/code-reviews/rejected-suggestions/5965e14_feat-changelog-and-sweep-4_PR169_phony-ordering.md
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{c,cc,cpp,cxx,h,hpp,hxx,m,mm}
📄 CodeRabbit inference engine (CLAUDE.md)
NEVER use
NOLINTto suppress clang-tidy warnings; ALWAYS fix the underlying issue
Files:
core/src/edge/attributed.ccore/src/fs/path_utils.ccore/src/cache/query.ccore/tests/fakes/git/fake_git_repository_port.ccore/include/gitmind/util/oid.hcore/include/gitmind/edge/internal/blob_identity.hcore/src/edge/internal/blob_identity.ccore/include/gitmind/cache.hcore/src/app/cache/cache_rebuild_service.ccore/src/edge/edge.ccore/src/util/oid.c
**/*.c
📄 CodeRabbit inference engine (AGENTS.md)
**/*.c: No use of VLAs (variable-length arrays) or variable shadowing; explicit C23 prototypes must be used.
All includes must use specific headers, ordered as per.clang-format, with grouping and no wildcards.
Use onlygm_snprintf,gm_strcpy_safe, andgm_memcpy_spanfor string/memory operations. Always check return codes and treat truncation/errors as non-successful.
Zero output buffers on error paths before formatting or copying data to prevent partial writes.
Prefer use ofGM_PATH_MAXfor all path and buffer allocations. Never useGM_PATH_MAX*2; allocate only if larger is required.
Files:
core/src/edge/attributed.ccore/src/fs/path_utils.ccore/src/cache/query.ccore/tests/fakes/git/fake_git_repository_port.ccore/src/edge/internal/blob_identity.ccore/src/app/cache/cache_rebuild_service.ccore/src/edge/edge.ccore/src/util/oid.c
**/*.{h,c}
📄 CodeRabbit inference engine (AGENTS.md)
All functions and variables must use
lower_snake_case(withgm_prefix); macros areUPPER_SNAKE_CASE; types end with_t; header guards areGITMIND_*.
Files:
core/src/edge/attributed.ccore/src/fs/path_utils.ccore/src/cache/query.ccore/tests/fakes/git/fake_git_repository_port.ccore/include/gitmind/util/oid.hcore/include/gitmind/edge/internal/blob_identity.hcore/src/edge/internal/blob_identity.ccore/include/gitmind/cache.hcore/src/app/cache/cache_rebuild_service.ccore/src/edge/edge.ccore/src/util/oid.c
core/tests/fakes/**
📄 CodeRabbit inference engine (AGENTS.md)
Each port must have a deterministic fake/mock adapter under
core/tests/fakes/with contract harnesses to test both real and fake invariants.
Files:
core/tests/fakes/git/fake_git_repository_port.c
core/tests/**/*.c
📄 CodeRabbit inference engine (AGENTS.md)
All tests must execute in Docker, avoid Git HEAD assumptions in bare repos, and must seed test branches as necessary.
Files:
core/tests/fakes/git/fake_git_repository_port.c
core/include/gitmind/**/*.h
📄 CodeRabbit inference engine (AGENTS.md)
core/include/gitmind/**/*.h: Each public struct or enum should be defined in its own header file (1 struct/enum per header). Internal-only types belong incore/include/gitmind/<module>/internal/.
All public headers must have C++ linkage guards (extern "C"), correct include guards, and pass header compile checks (make header-compile).
Files:
core/include/gitmind/util/oid.hcore/include/gitmind/edge/internal/blob_identity.hcore/include/gitmind/cache.h
**/*.h
📄 CodeRabbit inference engine (AGENTS.md)
Public ABI changes in structs must be append-only (add new fields at the end); mark deprecated fields, do not remove or reorder.
Files:
core/include/gitmind/util/oid.hcore/include/gitmind/edge/internal/blob_identity.hcore/include/gitmind/cache.h
core/include/gitmind/*.h
📄 CodeRabbit inference engine (AGENTS.md)
Public headers must be umbrella-safe: able to be included standalone, have correct header guards, and possess
extern "C"when included in C++.
Files:
core/include/gitmind/cache.h
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/203f4e3539b1d8fc73b641e94b0a420f2e592a14.md
🧠 Learnings (14)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Version and migrate cache formats when changing the hash function (e.g., raw OID vs SHA); auto-rebuild or reject mismatched versions
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/include/gitmind/edge.h : Avoid struct bloat: do not store both legacy SHA arrays and OIDs long-term in gm_edge_t; deprecate and phase out legacy SHA fields
Applied to files:
core/src/edge/attributed.ccore/include/gitmind/edge/internal/blob_identity.hcore/src/edge/internal/blob_identity.ccore/src/edge/edge.c
📚 Learning: 2025-09-13T03:13:54.145Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-13T03:13:54.145Z
Learning: Applies to include/gitmind.h : Maintain umbrella API at include/gitmind.h
Applied to files:
core/src/edge/attributed.ccore/src/cache/query.ccore/src/edge/edge.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/include/gitmind/cbor/keys.h : Define CBOR field keys as named constants/enums in a single header and include it where parsing/encoding occurs
Applied to files:
core/src/edge/attributed.ccore/src/cache/query.ccore/src/edge/edge.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/edge/edge.c : gm_edge_equal() must compare OIDs first and only fall back to SHA when OIDs are unset/zero; never treat mismatched OIDs as equal due to matching SHAs
Applied to files:
core/src/edge/attributed.ccore/include/gitmind/edge/internal/blob_identity.hcore/src/edge/internal/blob_identity.ccore/src/app/cache/cache_rebuild_service.ccore/src/edge/edge.c
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to **/*.c : Prefer use of `GM_PATH_MAX` for all path and buffer allocations. Never use `GM_PATH_MAX*2`; allocate only if larger is required.
Applied to files:
core/src/fs/path_utils.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Applied to files:
core/src/cache/query.ccore/include/gitmind/util/oid.hcore/src/app/cache/cache_rebuild_service.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Version and migrate cache formats when changing the hash function (e.g., raw OID vs SHA); auto-rebuild or reject mismatched versions
Applied to files:
core/src/cache/query.ccore/include/gitmind/cache.hcore/src/app/cache/cache_rebuild_service.c
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to core/include/gitmind/*.h : Public headers must be umbrella-safe: able to be included standalone, have correct header guards, and possess `extern "C"` when included in C++.
Applied to files:
core/src/cache/query.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/journal/{reader,writer}.c : Eliminate CBOR magic numbers; use centralized keys from gitmind/cbor/keys.h
Applied to files:
core/src/cache/query.ccore/src/edge/edge.c
📚 Learning: 2025-09-13T03:13:54.145Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-13T03:13:54.145Z
Learning: Applies to {include,core/include}/**/*.h : Header guards use GITMIND_* naming
Applied to files:
core/src/cache/query.c
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to **/*.c : Use only `gm_snprintf`, `gm_strcpy_safe`, and `gm_memcpy_span` for string/memory operations. Always check return codes and treat truncation/errors as non-successful.
Applied to files:
core/tests/fakes/git/fake_git_repository_port.c
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/**/*.{c,h} : Use bounded string functions (e.g., gm_snprintf) and check return values for overflow; ensure explicit NUL termination
Applied to files:
core/tests/fakes/git/fake_git_repository_port.c
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to core/src/domain/edge/** : Edge Graph Domain logic must reside in `core/src/domain/edge/**` (headers in `core/include/gitmind/edge*.h`); enforce entities and services (edge validation, merge, hashing) as pure, deterministic modules with no direct IO.
Applied to files:
core/src/edge/edge.c
🧬 Code graph analysis (6)
core/src/fs/path_utils.c (1)
core/include/gitmind/security/memory.h (1)
gm_memset_safe(47-59)
core/tests/fakes/git/fake_git_repository_port.c (1)
core/include/gitmind/util/memory.h (1)
gm_strcpy_safe(113-138)
core/include/gitmind/util/oid.h (1)
core/src/util/oid.c (2)
int(18-40)int(42-50)
core/include/gitmind/edge/internal/blob_identity.h (1)
core/src/edge/internal/blob_identity.c (1)
gm_result_void_t(13-45)
core/src/edge/internal/blob_identity.c (2)
core/include/gitmind/util/memory.h (1)
gm_memcpy_span(32-47)core/include/gitmind/security/memory.h (1)
gm_memset_safe(47-59)
core/src/util/oid.c (1)
core/include/gitmind/security/memory.h (1)
gm_memset_safe(47-59)
🔇 Additional comments (8)
meson.build (1)
118-118: New modules wired into the build.Good call adding
blob_identity.candoid.cto the Meson source list; that keeps the refreshed edge/OID helpers linked everywhere they’re needed.Also applies to: 134-134
core/include/gitmind/cache.h (1)
51-52: ABI note now tags the right field.Shifting the “struct tail” comment onto
cache_tip_oidavoids future confusion about which field was appended for ABI purposes.core/src/cache/query.c (1)
21-21: LGTM: correct include for new OID utilities.core/src/app/cache/cache_rebuild_service.c (2)
30-30: LGTM: include oid.h and centralize hex formatting.
139-141: LGTM: oid_to_hex delegates to gm_oid_to_hex.core/src/edge/attributed.c (3)
14-14: LGTM: central blob-identity include.
Keeps identity logic in one place.
317-321: LGTM: delegate source identity to gm_edge_resolve_blob_identity.
Reduces duplication and ensures uniform OID/SHA handling.Based on learnings
324-328: LGTM: delegate target identity to gm_edge_resolve_blob_identity.
Symmetric with source path.
Comment on lines
+20
to
+23
| * On success, both the preferred OID (`out_oid`) and the legacy SHA-1 buffer | ||
| * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ` | ||
| * exceeds `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain | ||
| * deterministic contents. Callers must provide non-null pointers. |
Contributor
There was a problem hiding this comment.
Fix legacy buffer padding description.
The implementation zero-fills the legacy SHA buffer only when GM_OID_RAWSZ is smaller than GM_SHA1_SIZE. The doc currently says “exceeds,” so the guidance is inverted. Please update the phrasing so callers understand when padding happens.
- * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ`
- * exceeds `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain
+ * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ`
+ * is smaller than `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| * On success, both the preferred OID (`out_oid`) and the legacy SHA-1 buffer | |
| * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ` | |
| * exceeds `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain | |
| * deterministic contents. Callers must provide non-null pointers. | |
| * On success, both the preferred OID (`out_oid`) and the legacy SHA-1 buffer | |
| * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ` | |
| * is smaller than `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain | |
| * deterministic contents. Callers must provide non-null pointers. |
🤖 Prompt for AI Agents
In core/include/gitmind/edge/internal/blob_identity.h around lines 20 to 23, the
comment incorrectly states that the legacy SHA buffer is zero-padded when
GM_OID_RAWSZ "exceeds" GM_SHA1_SIZE; update the phrasing to say that the legacy
buffer is zero-padded when GM_OID_RAWSZ is smaller than GM_SHA1_SIZE (i.e., when
the preferred OID raw size is less than the legacy SHA-1 size), so callers know
padding happens to fill the remainder of the legacy buffer to GM_SHA1_SIZE;
ensure callers still know to provide non-null pointers.
Comment on lines
+27
to
+38
| const size_t required = (len * 2U) + 1U; | ||
| if (out_size < required) { | ||
| gm_memset_safe(out, out_size, 0, out_size); | ||
| return GM_ERR_BUFFER_TOO_SMALL; | ||
| } | ||
|
|
||
| for (size_t i = 0; i < len; ++i) { | ||
| unsigned byte = bytes[i]; | ||
| out[i * 2U] = KHexDigits[(byte >> KNibbleBits) & KNibbleMask]; | ||
| out[(i * 2U) + 1U] = KHexDigits[byte & KNibbleMask]; | ||
| } | ||
| out[len * 2U] = '\0'; |
Contributor
There was a problem hiding this comment.
Guard against overflow before sizing the hex buffer
required = (len * 2U) + 1U can overflow size_t for large inputs, which lets the length check pass with a wrapped value and we then scribble past out while the loop iterates len times. Please short-circuit when len exceeds the safe range before doing the multiply.
@@
- const size_t required = (len * 2U) + 1U;
+ if (len > (SIZE_MAX - 1U) / 2U) {
+ gm_memset_safe(out, out_size, 0, out_size);
+ return GM_ERR_INVALID_ARGUMENT;
+ }
+
+ const size_t required = (len * 2U) + 1U;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const size_t required = (len * 2U) + 1U; | |
| if (out_size < required) { | |
| gm_memset_safe(out, out_size, 0, out_size); | |
| return GM_ERR_BUFFER_TOO_SMALL; | |
| } | |
| for (size_t i = 0; i < len; ++i) { | |
| unsigned byte = bytes[i]; | |
| out[i * 2U] = KHexDigits[(byte >> KNibbleBits) & KNibbleMask]; | |
| out[(i * 2U) + 1U] = KHexDigits[byte & KNibbleMask]; | |
| } | |
| out[len * 2U] = '\0'; | |
| if (len > (SIZE_MAX - 1U) / 2U) { | |
| gm_memset_safe(out, out_size, 0, out_size); | |
| return GM_ERR_INVALID_ARGUMENT; | |
| } | |
| const size_t required = (len * 2U) + 1U; | |
| if (out_size < required) { | |
| gm_memset_safe(out, out_size, 0, out_size); | |
| return GM_ERR_BUFFER_TOO_SMALL; | |
| } | |
| for (size_t i = 0; i < len; ++i) { | |
| unsigned byte = bytes[i]; | |
| out[i * 2U] = KHexDigits[(byte >> KNibbleBits) & KNibbleMask]; | |
| out[(i * 2U) + 1U] = KHexDigits[byte & KNibbleMask]; | |
| } | |
| out[len * 2U] = '\0'; |
🤖 Prompt for AI Agents
In core/src/util/oid.c around lines 27-38, the computed required = (len * 2U) +
1U can overflow size_t for large len; before performing the multiply, check that
len does not exceed (SIZE_MAX - 1) / 2 (or equivalent safe_max) and if it does,
zero the output buffer via gm_memset_safe and return GM_ERR_BUFFER_TOO_SMALL (or
an appropriate error). After that guard, compute required normally, perform the
existing out_size check and proceed with the hex conversion.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/review-artifact-cleanup.yml(1 hunks)docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Version and migrate cache formats when changing the hash function (e.g., raw OID vs SHA); auto-rebuild or reject mismatched versions
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (6)
.github/workflows/coderabbit-status.yml (2)
11-14: Reduce duplicate runs on rapid updates.Add a concurrency group to cancel in‑progress runs on synchronize events.
Apply this diff under the job:
jobs: coderabbit: runs-on: ubuntu-latest + concurrency: + group: coderabbit-status-${{ github.event.pull_request.number || github.run_id }} + cancel-in-progress: true
19-19: Option: pin Python to a specific minor for reproducibility.Pin to a known-good version to avoid surprises from future 3.x releases.
Apply this diff if desired:
- python-version: '3.x' + python-version: '3.12'tools/review/check_coderabbit_threads.py (4)
19-21: Make the bot login configurable via env.Different installations may use another bot login; allow override without code changes.
Apply this diff:
-GRAPHQL_ENDPOINT = "https://api.github.com/graphql" -CODERABBIT_LOGIN = "coderabbitai" +GRAPHQL_ENDPOINT = "https://api.github.com/graphql" +CODERABBIT_LOGIN = os.environ.get("CODERABBIT_LOGIN", "coderabbitai")
23-37: Harden GitHub GraphQL call (UA, raise_for_status, request exceptions).Improves diagnostics and resilience; also resolves Ruff TRY003 by relying on standard exceptions.
Apply this diff:
def github_graphql(token: str, query: str, variables: dict) -> dict: - response = requests.post( - GRAPHQL_ENDPOINT, - json={"query": query, "variables": variables}, - headers={"Authorization": f"Bearer {token}", "Accept": "application/vnd.github+json"}, - timeout=30, - ) - if response.status_code != 200: - raise RuntimeError( - f"GitHub GraphQL API returned {response.status_code}: {response.text}" - ) - data = response.json() + headers = { + "Authorization": f"Bearer {token}", + "Accept": "application/vnd.github+json", + "User-Agent": "git-mind/CodeRabbitStatus", + } + try: + response = requests.post( + GRAPHQL_ENDPOINT, + json={"query": query, "variables": variables}, + headers=headers, + timeout=30, + ) + response.raise_for_status() + data = response.json() + except requests.exceptions.RequestException as e: + raise RuntimeError(f"GitHub GraphQL request failed: {e}") from e if "errors" in data: raise RuntimeError(f"GitHub GraphQL error: {data['errors']}") return data["data"]
105-109: Allow GH_TOKEN fallback to ease local runs and self-hosted runners.Apply this diff:
- token = os.environ.get("GITHUB_TOKEN") + token = os.environ.get("GITHUB_TOKEN") or os.environ.get("GH_TOKEN")
31-33: Optional: align with Ruff TRY003.If Ruff is enforced, prefer raising standard exceptions (HTTPError) or shorter messages; the previous diff addresses most of this.
Also applies to: 36-36, 75-77
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/coderabbit-status.yml(1 hunks)docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md(1 hunks)tools/review/check_coderabbit_threads.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Version and migrate cache formats when changing the hash function (e.g., raw OID vs SHA); auto-rebuild or reject mismatched versions
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/docs/architecture/deprecations/** : Document migration paths for breaking changes (e.g., cache hash format, SHA→OID) under architecture deprecations
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Applied to files:
docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/include/gitmind/edge.h : Avoid struct bloat: do not store both legacy SHA arrays and OIDs long-term in gm_edge_t; deprecate and phase out legacy SHA fields
Applied to files:
docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/edge/edge.c : gm_edge_equal() must compare OIDs first and only fall back to SHA when OIDs are unset/zero; never treat mismatched OIDs as equal due to matching SHAs
Applied to files:
docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
🪛 Ruff (0.13.1)
tools/review/check_coderabbit_threads.py
31-33: Avoid specifying long messages outside the exception class
(TRY003)
36-36: Avoid specifying long messages outside the exception class
(TRY003)
75-77: Avoid specifying long messages outside the exception class
(TRY003)
🔇 Additional comments (2)
.github/workflows/coderabbit-status.yml (1)
3-6: Note: pull_request_target won’t run this workflow for this PR.pull_request_target uses the workflow from the base branch; since this file is new, it won’t execute until after merge. Confirm that this is intentional.
tools/review/check_coderabbit_threads.py (1)
40-95: LGTM: pagination and unresolved-thread filtering.Correctly paginates reviewThreads and filters unresolved where the last comment is by the bot.
If the bot login can vary across orgs (e.g., “coderabbitinc”), confirm the final CODERABBIT_LOGIN value matches your installation.
…chore/code-rabbit-cleanup
…chore/code-rabbit-cleanup
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/auto-seed-review.yml(2 hunks).github/workflows/review-artifact-cleanup.yml(1 hunks)docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md(1 hunks)docs/code-reviews/PR172/82dab217893b6ee8bb8dcdca2217f9900a06b76f.md(1 hunks)docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.mddocs/code-reviews/PR172/82dab217893b6ee8bb8dcdca2217f9900a06b76f.md
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Version and migrate cache formats when changing the hash function (e.g., raw OID vs SHA); auto-rebuild or reject mismatched versions
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/include/gitmind/edge.h : Avoid struct bloat: do not store both legacy SHA arrays and OIDs long-term in gm_edge_t; deprecate and phase out legacy SHA fields
Applied to files:
docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/82dab217893b6ee8bb8dcdca2217f9900a06b76f.md
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Applied to files:
docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.md
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to docs/**/*.md : Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include `api_version`.
Applied to files:
docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md
🔇 Additional comments (2)
.github/workflows/review-artifact-cleanup.yml (1)
17-47: Checkout must land on the base branch before pushing.We’re still pushing from a detached
HEAD, sogit pusherrors with “You are not currently on a branch” and the cleanup never lands. Check out the PR’s base branch (or otherwise attach to a branch) before staging deletions. This was already flagged and remains unresolved.- name: Checkout repository uses: actions/checkout@v4 with: fetch-depth: 0 + ref: ${{ github.event.pull_request.base.ref }}docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md (1)
1-24: Front matter title and required TOC are missing.Docs under
docs/**must keep the front-mattertitleidentical to the H1 and include an explicit “## Table of Contents” immediately after it. Please align the title and add the TOC block so the file complies.--- -title: 5add14fcdabafff59a99ea484d691140afdb68c3.md +title: Code Review Feedback description: Preserved review artifacts and rationale. audience: [contributors] domain: [quality] tags: [review] status: archive --- # Code Review Feedback + +## Table of Contents +- [Code Review Feedback](#code-review-feedback) +- [CODE REVIEW FEEDBACK](#code-review-feedback-1)As per coding guidelines.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md (1)
12-15: Keep the TOC in sync with the document sections.The “## Table of Contents” block skips the “## Overture from P.R. PhiedBach” section, so the navigation is incomplete. Please add that entry so the TOC reflects every top-level heading.
## Table of Contents - [Code Review Feedback](#code-review-feedback) +- [Overture from P.R. PhiedBach](#overture-from-pr-phiedbach) - [CODE REVIEW FEEDBACK](#code-review-feedback-1)As per coding guidelines
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
.github/workflows/coderabbit-status.yml(1 hunks).github/workflows/review-artifact-cleanup.yml(1 hunks)core/src/util/oid.c(1 hunks)docs/code-reviews/PR172/203f4e3539b1d8fc73b641e94b0a420f2e592a14.md(1 hunks)docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.md(1 hunks)docs/code-reviews/PR172/7b7b5f565ef23d959b126b0df50e0a3992c52da2.md(1 hunks)docs/code-reviews/PR172/82dab217893b6ee8bb8dcdca2217f9900a06b76f.md(1 hunks)docs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md(1 hunks)docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.md(1 hunks)docs/code-reviews/PR172/d11ee830d5615e5582114d625a52283760d61767.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- docs/code-reviews/PR172/82dab217893b6ee8bb8dcdca2217f9900a06b76f.md
- docs/code-reviews/PR172/203f4e3539b1d8fc73b641e94b0a420f2e592a14.md
- core/src/util/oid.c
- .github/workflows/review-artifact-cleanup.yml
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/d11ee830d5615e5582114d625a52283760d61767.mddocs/code-reviews/PR172/7b7b5f565ef23d959b126b0df50e0a3992c52da2.mddocs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.mddocs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
🧠 Learnings (5)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/include/gitmind/edge.h : Avoid struct bloat: do not store both legacy SHA arrays and OIDs long-term in gm_edge_t; deprecate and phase out legacy SHA fields
Applied to files:
docs/code-reviews/PR172/d11ee830d5615e5582114d625a52283760d61767.mddocs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Applied to files:
docs/code-reviews/PR172/d11ee830d5615e5582114d625a52283760d61767.mddocs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
📚 Learning: 2025-09-28T05:49:55.962Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: AGENTS.md:0-0
Timestamp: 2025-09-28T05:49:55.962Z
Learning: Applies to docs/**/*.md : Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include `api_version`.
Applied to files:
docs/code-reviews/PR172/5add14fcdabafff59a99ea484d691140afdb68c3.mddocs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/edge/edge.c : gm_edge_equal() must compare OIDs first and only fall back to SHA when OIDs are unset/zero; never treat mismatched OIDs as equal due to matching SHAs
Applied to files:
docs/code-reviews/PR172/b22c22398de39c4ab93e1c747b1122d2241eed22.mddocs/code-reviews/PR172/8a32c6a810ebf632709cec6c928381c9c47fdee9.md
Comment on lines
+1
to
+24
| --- | ||
| title: 7b7b5f565ef23d959b126b0df50e0a3992c52da2.md | ||
| description: Preserved review artifacts and rationale. | ||
| audience: [contributors] | ||
| domain: [quality] | ||
| tags: [review] | ||
| status: archive | ||
| --- | ||
|
|
||
| # Code Review Feedback | ||
|
|
||
| | Date | Agent | SHA | Branch | PR | | ||
| |------|-------|-----|--------|----| | ||
| | 2025-09-28 | CodeRabbit (and reviewers) | `7b7b5f565ef23d959b126b0df50e0a3992c52da2` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | | ||
|
|
||
| ## CODE REVIEW FEEDBACK | ||
|
|
||
| ### General comment — coderabbitai[bot] | ||
|
|
||
| ```text | ||
| <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | ||
| <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> | ||
|
|
||
| > [!NOTE] |
Contributor
There was a problem hiding this comment.
Doc front matter + headings violate required structure. The doc rules demand the front‑matter title match the H1, and a ## Table of Contents section is mandatory. Here, the title is the SHA string while the H1 is “Code Review Feedback”, and there’s no TOC. Please align the title with the H1 and add the TOC before the remaining sections. As per coding guidelines
-title: 7b7b5f565ef23d959b126b0df50e0a3992c52da2.md
+title: Code Review Feedback
@@
-# Code Review Feedback
+# Code Review Feedback
+
+## Table of Contents
+
+- [Code Review Feedback](#code-review-feedback)
+- [CODE REVIEW FEEDBACK](#code-review-feedback-1)
+- [General comment — coderabbitai\[\bot\]](#general-comment--coderabbitai-bot)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| --- | |
| title: 7b7b5f565ef23d959b126b0df50e0a3992c52da2.md | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| | Date | Agent | SHA | Branch | PR | | |
| |------|-------|-----|--------|----| | |
| | 2025-09-28 | CodeRabbit (and reviewers) | `7b7b5f565ef23d959b126b0df50e0a3992c52da2` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | | |
| ## CODE REVIEW FEEDBACK | |
| ### General comment — coderabbitai[bot] | |
| ```text | |
| <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | |
| <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> | |
| > [!NOTE] | |
| --- | |
| title: Code Review Feedback | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| ## Table of Contents | |
| - [Code Review Feedback](#code-review-feedback) | |
| - [CODE REVIEW FEEDBACK](#code-review-feedback-1) | |
| - [General comment — coderabbitai[bot]](#general-comment--coderabbitai-bot) | |
| | Date | Agent | SHA | Branch | PR | | |
| |------|-------|-----|--------|----| | |
| | 2025-09-28 | CodeRabbit (and reviewers) | `7b7b5f565ef23d959b126b0df50e0a3992c52da2` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | | |
| ## CODE REVIEW FEEDBACK | |
| ### General comment — coderabbitai[bot] | |
🤖 Prompt for AI Agents
In docs/code-reviews/PR172/7b7b5f565ef23d959b126b0df50e0a3992c52da2.md lines
1-24, the front-matter title does not match the H1 and the required "## Table of
Contents" section is missing; update the YAML front-matter title to exactly
match the H1 "Code Review Feedback" (remove the SHA string), and insert a "##
Table of Contents" header immediately after the H1 with appropriate links (e.g.,
to CODE REVIEW FEEDBACK and any subsections) so the document follows the
required structure.
Comment on lines
+2
to
+11
| title: d11ee830d5615e5582114d625a52283760d61767.md | ||
| description: Preserved review artifacts and rationale. | ||
| audience: [contributors] | ||
| domain: [quality] | ||
| tags: [review] | ||
| status: archive | ||
| --- | ||
|
|
||
| # Code Review Feedback | ||
|
|
Contributor
There was a problem hiding this comment.
Restore doc title alignment and required TOC section.
Front matter title still uses the SHA instead of matching the H1 (Code Review Feedback), and the mandatory ## Table of Contents block after the H1 is missing. Both violate the docs/ guidelines. Please align the title and add the TOC. As per coding guidelines
---
-title: d11ee830d5615e5582114d625a52283760d61767.md
+title: Code Review Feedback
description: Preserved review artifacts and rationale.
audience: [contributors]
domain: [quality]
tags: [review]
status: archive
---
# Code Review Feedback
+
+## Table of Contents
+- [Code Review Feedback](#code-review-feedback)
+- [CODE REVIEW FEEDBACK](#code-review-feedback-1)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| title: d11ee830d5615e5582114d625a52283760d61767.md | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| --- | |
| title: Code Review Feedback | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| ## Table of Contents | |
| - [Code Review Feedback](#code-review-feedback) | |
| - [CODE REVIEW FEEDBACK](#code-review-feedback-1) |
🤖 Prompt for AI Agents
In docs/code-reviews/PR172/d11ee830d5615e5582114d625a52283760d61767.md around
lines 2 to 11, the front-matter title still contains the commit SHA and the
mandatory "## Table of Contents" section is missing; update the front-matter
title to "Code Review Feedback" to match the H1 and add a "## Table of Contents"
heading immediately after the H1 (populate entries if required by guidelines) so
the file conforms to the docs/ guidelines.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/code-reviews/PR172/5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Docs must start with front matter, have a single H1 heading, an explicit '## Table of Contents', title matching the H1, and API docs must include
api_version.
Files:
docs/code-reviews/PR172/5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/core/src/cache/{builder,query}.c : Keep naming consistent with OID terminology (e.g., OID_HASH_MULTIPLIER, oid_hash) after migration from SHA
Learnt from: flyingrobots
PR: neuroglyph/git-mind#169
File: docs/templates/code-review-feedback.md:26-33
Timestamp: 2025-09-16T17:10:27.477Z
Learning: The user (flyingrobots) uses Obsidian to view/edit Markdown files and prefers to keep Obsidian-specific syntax like collapsible callout markers (e.g., `[!NOTE]-` for collapsible callouts) even if they're not GitHub-compatible.
📚 Learning: 2025-09-19T03:59:13.318Z
Learnt from: CR
PR: neuroglyph/git-mind#0
File: docs/code-reviews/CLAUDE.md:0-0
Timestamp: 2025-09-19T03:59:13.318Z
Learning: Applies to docs/code-reviews/docs/architecture/deprecations/** : Document migration paths for breaking changes (e.g., cache hash format, SHA→OID) under architecture deprecations
Applied to files:
docs/code-reviews/PR172/5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md
Comment on lines
+1
to
+18
| --- | ||
| title: 5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md | ||
| description: Preserved review artifacts and rationale. | ||
| audience: [contributors] | ||
| domain: [quality] | ||
| tags: [review] | ||
| status: archive | ||
| --- | ||
|
|
||
| # Code Review Feedback | ||
|
|
||
| | Date | Agent | SHA | Branch | PR | | ||
| |------|-------|-----|--------|----| | ||
| | 2025-09-29 | CodeRabbit (and reviewers) | `5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | | ||
|
|
||
| ## CODE REVIEW FEEDBACK | ||
|
|
||
| ### core/include/gitmind/edge/internal/blob_identity.h:23 — coderabbitai[bot] |
Contributor
There was a problem hiding this comment.
Restore doc title/TOC to meet docs guidelines.
Docs under docs/** must keep the front-matter title identical to the H1 and include a ## Table of Contents immediately after the H1. Here the title still uses the SHA and the TOC section is missing. Please align both so the file complies. As per coding guidelines.
---
-title: 5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md
+title: Code Review Feedback
description: Preserved review artifacts and rationale.
audience: [contributors]
domain: [quality]
tags: [review]
status: archive
---
# Code Review Feedback
+
+## Table of Contents
+- [Code Review Feedback](#code-review-feedback)
+- [CODE REVIEW FEEDBACK](#code-review-feedback-1)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| --- | |
| title: 5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| | Date | Agent | SHA | Branch | PR | | |
| |------|-------|-----|--------|----| | |
| | 2025-09-29 | CodeRabbit (and reviewers) | `5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | | |
| ## CODE REVIEW FEEDBACK | |
| ### core/include/gitmind/edge/internal/blob_identity.h:23 — coderabbitai[bot] | |
| --- | |
| title: Code Review Feedback | |
| description: Preserved review artifacts and rationale. | |
| audience: [contributors] | |
| domain: [quality] | |
| tags: [review] | |
| status: archive | |
| --- | |
| # Code Review Feedback | |
| ## Table of Contents | |
| - [Code Review Feedback](#code-review-feedback) | |
| - [CODE REVIEW FEEDBACK](#code-review-feedback-1) | |
| | Date | Agent | SHA | Branch | PR | | |
| |------|-------|-----|--------|----| | |
| | 2025-09-29 | CodeRabbit (and reviewers) | `5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c` | [chore/code-rabbit-cleanup](https://github.com/neuroglyph/git-mind/tree/chore/code-rabbit-cleanup "neuroglyph/git-mind:chore/code-rabbit-cleanup") | [PR#172](https://github.com/neuroglyph/git-mind/pull/172) | |
🤖 Prompt for AI Agents
In docs/code-reviews/PR172/5402cadb5e7a3f71e0bee7a1e05a1f5034d4fc3c.md around
lines 1 to 18, the front-matter title currently contains the SHA and the
document lacks a "## Table of Contents" immediately after the H1; update the
YAML front-matter title to be identical to the H1 text (replace the SHA with the
human-readable title used as the file H1) and insert a "## Table of Contents"
header directly after the H1, ensuring the H1 and front-matter title match
exactly and the TOC section is present per docs guidelines.
This was referenced Sep 29, 2025
Merged
This was referenced Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation
Chores