chore/code rabbit cleanup

.github/workflows/auto-seed-review.yml

@@ -33,14 +33,14 @@ jobs:
             --pr "$PR" --out docs/code-reviews
       - name: Commit and push
         run: |
-          git config user.name  "git-mind-bot"
-          git config user.email "gitmind-bot@example.com"
+          git config user.name  "P.R. PhiedBach"
+          git config user.email "phiedbach@bikeshed.dungeon"
           git add docs/code-reviews
           if git diff --cached --quiet; then
             echo "No changes to commit"; exit 0; fi
           PR=${{ github.event.number }}
           SHA=${{ github.event.pull_request.head.sha }}
-          git commit -m "chore(review): seed feedback for PR #$PR ($SHA)"
+          git commit -m "opus(PR#$PR): seed rehearsal score ($SHA)"
           git push
 
   seed-fork:
@@ -74,12 +74,12 @@ jobs:
           python3 tools/review/seed_feedback_from_github.py \
             --owner "${GITHUB_REPOSITORY%%/*}" --repo "${GITHUB_REPOSITORY##*/}" \
             --pr "$PR" --out docs/code-reviews
-          git config user.name  "git-mind-bot"
-          git config user.email "gitmind-bot@example.com"
+          git config user.name  "P.R. PhiedBach"
+          git config user.email "phiedbach@bikeshed.dungeon"
           git add docs/code-reviews
           if git diff --cached --quiet; then
             echo "No seeded changes to commit"; exit 0; fi
-          git commit -m "chore(review): seed feedback for PR #$PR"
+          git commit -m "opus(PR#$PR): seed rehearsal score"
           # Attempt to push using GITMIND_PR_WORKSHEET_BOT if provided and contributor allows edits
           if [ -n "$GITMIND_PR_WORKSHEET_BOT" ]; then
             repo_full="${{ github.event.pull_request.head.repo.full_name }}"

.github/workflows/coderabbit-status.yml

@@ -0,0 +1,31 @@
+name: CodeRabbit Status
+
+on:
+  pull_request_target:
+    types: [opened, reopened, synchronize, ready_for_review]
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  coderabbit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install requests
+      - name: Check unresolved CodeRabbit threads
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          python3 tools/review/check_coderabbit_threads.py \
+            --owner "${GITHUB_REPOSITORY%%/*}" \
+            --repo "${GITHUB_REPOSITORY##*/}" \
+            --pr ${{ github.event.number }}

.github/workflows/review-artifact-cleanup.yml

@@ -0,0 +1,48 @@
+name: Cleanup Review Worksheets
+
+on:
+  pull_request:
+    types: [closed]
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  cleanup:
+    if: github.event.pull_request.merged == true
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          ref: ${{ github.event.pull_request.base.ref }}
+
+      - name: Configure git
+        run: |
+          git config user.name "P.R. PhiedBach"
+          git config user.email "phiedbach@bikeshed.dungeon"
+
+      - name: Remove review artifacts
+        run: |
+          pr_number=${{ github.event.pull_request.number }}
+          review_dir="docs/code-reviews/PR${pr_number}"
+          if [ -d "$review_dir" ]; then
+            git rm -r "$review_dir"
+          fi
+          # Remove any rejected-suggestion docs tied to this PR number
+          git ls-files "docs/code-reviews/rejected-suggestions/*_${pr_number}_*.md" | xargs -r git rm
+
+      - name: Commit cleanup
+        run: |
+          if git diff --cached --quiet; then
+            echo "No review artifacts to delete; skipping commit."
+            exit 0
+          fi
+          git commit -m "coda(PR#${{ github.event.pull_request.number }}): archive rehearsal notes"
+
+      - name: Push cleanup commit
+        run: |
+          git push

AGENTS.md

@@ -438,6 +438,20 @@ See archives under `docs/activity/` for older logs.
 - CodeRabbit pass (batch 2): accepted output-zeroing and error-propagation notes—commit creation now clears result OIDs up front, commit message reads null-init outputs, hook blob lookups zero result buffers and distinguish NOT_FOUND from real failures, commit walks honour `GM_CALLBACK_STOP`, and the fake port header owns its std includes.
 - CodeRabbit pass (batch 3): reaffirmed the wildebeest benchmark already routes queries via `gm_oid_t`, clarified detached-HEAD fallback inside `gm_hook_get_blob_sha`, and brought the PR171 review docs in line with the front-matter/TOC guidelines.
 
+### 2025-09-28
+- Hardened port usage: journal writer now bubbles explicit commit/ref update codes and retries fast-forward only once; cache rebuild composes a parent-aware commit spec and refuses non-fast-forward updates; libgit2 adapter enforces ancestry checks via `git_graph_descendant_of`.
+- Filesystem polish: `gm_fs_path_normalize_logical`/`basename_append` zero outputs on failure paths, guard short buffers, and cap segment arrays; posix temp adapter wraps `_GNU_SOURCE` in an `#ifndef` so clang stays quiet.
+- Fake git port + tests updated to use `gm_memset_safe`/`gm_strcpy_safe`, keeping parity with production safety helpers.
+- CI status: `make ci-local` passes after the fast-forward guard, cache parent wiring, and path-utils fixes (clang-tidy clean).
+- Outstanding follow-ups for future-me:
+  * Extract the duplicated `resolve_blob_identity` helper (edge + edge_attributed) into a shared utility so we maintain one implementation.
+  * Replace remaining `git_oid_tostr` usage with a core-level `gm_oid_to_hex` helper and drop the remaining direct libgit2 includes in cache/query paths.
+  * Sweep for any lingering `fprintf` debug traces before shipping.
+  * Run CodeRabbit worksheet checker again after touching docs to ensure no new “Decision:” gaps.
+- Today’s continuation: pulled the trigger on that list—extracted `gm_edge_resolve_blob_identity` into `core/src/edge/internal/blob_identity.c`, introduced `gm_bytes_to_hex`/`gm_oid_to_hex`, and refactored cache rebuild/query to drop `git_oid_fmt/tostr`; `make ci-local` is green and `tools/review/check_worksheets.py docs/code-reviews/PR171/*.md` still flags the known undecided sections (see console), so next slot should be worksheet triage + CodeRabbit replies.
+- Follow-up (same day): cleaned up CodeRabbit’s fake-port feedback—fake commit/update paths now surface `gm_strcpy_safe` truncations, the shared OID helpers carry project-compliant naming/includes, and the deleted worksheet directory is ready for a fresh seed if we decide to log post-merge notes.
+- Quick-start when you return: rerun `make ci-local` if you touch the cache/journal surface, then tackle the shared blob helper → oid hex helper chain; once that’s in place, prep the PR summary referencing the fast-forward protections.
+
 ## Next Steps (handoff checklist)
 - Complete on-disk cache migration to OID-only storage and naming; ensure rebuild and fallback readers handle both formats or gate with a one-time migration.
 - Extend journal CBOR schema to store OIDs explicitly (not only derivable from legacy fields); update reader/writer and consumers.

core/include/gitmind/cache.h

@@ -48,8 +48,8 @@ typedef struct {
     uint32_t shard_bits;       /**< Number of bits for sharding */
     uint32_t version;          /**< Cache format version */
     char branch[GM_CACHE_BRANCH_NAME_SIZE];           /**< Branch name (may be truncated if too long) */
-    gm_oid_t journal_tip_oid_bin; /**< OID of last processed journal commit (preferred). Added at struct tail to preserve ABI layout. */
-    gm_oid_t cache_tip_oid;        /**< OID of cache commit for this branch. */
+    gm_oid_t journal_tip_oid_bin; /**< OID of last processed journal commit (preferred). */
+    gm_oid_t cache_tip_oid;       /**< OID of cache commit for this branch. Added at struct tail to preserve ABI layout. */
 } gm_cache_meta_t;
 
 /**

core/include/gitmind/edge/internal/blob_identity.h

@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: LicenseRef-MIND-UCAL-1.0 */
+/* © 2025 J. Kirby Ross / Neuroglyph Collective */
+
+#ifndef GITMIND_EDGE_INTERNAL_BLOB_IDENTITY_H
+#define GITMIND_EDGE_INTERNAL_BLOB_IDENTITY_H
+
+#include <stdint.h>
+
+#include "gitmind/context.h"
+#include "gitmind/result.h"
+#include "gitmind/types.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * Resolve the blob identity for a file path using the current repository head.
+ *
+ * On success, both the preferred OID (`out_oid`) and the legacy SHA-1 buffer
+ * (`legacy_sha`, sized to `GM_SHA1_SIZE`) are populated. When `GM_OID_RAWSZ`
+ * exceeds `GM_SHA1_SIZE`, the legacy buffer is zero-padded to maintain
+ * deterministic contents. Callers must provide non-null pointers.
+ */
+GM_NODISCARD gm_result_void_t gm_edge_resolve_blob_identity(
+    gm_context_t *ctx,
+    const char *path,
+    gm_oid_t *out_oid,
+    uint8_t *legacy_sha);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* GITMIND_EDGE_INTERNAL_BLOB_IDENTITY_H */

core/include/gitmind/util/oid.h

@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: LicenseRef-MIND-UCAL-1.0 */
+/* © 2025 J. Kirby Ross / Neuroglyph Collective */
+
+#ifndef GITMIND_UTIL_OID_H
+#define GITMIND_UTIL_OID_H
+
+#include <stddef.h>
+#include <stdint.h>
+
+#include "gitmind/result.h"
+#include "gitmind/types.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * Convert raw bytes to a lowercase hexadecimal string.
+ *
+ * @param bytes     Input byte array
+ * @param len       Number of bytes to convert
+ * @param out       Output buffer for the hex string
+ * @param out_size  Size of the output buffer in bytes
+ * @return GM_OK on success, GM_ERR_INVALID_ARGUMENT or GM_ERR_BUFFER_TOO_SMALL otherwise
+ */
+GM_NODISCARD int gm_bytes_to_hex(const uint8_t *bytes, size_t len,
+                                 char *out, size_t out_size);
+
+/**
+ * Convert a gm_oid_t into its hexadecimal string form.
+ *
+ * @param oid       Pointer to the OID to encode
+ * @param out       Output buffer for the hex string (including null terminator)
+ * @param out_size  Size of the output buffer in bytes
+ * @return GM_OK on success, GM_ERR_INVALID_ARGUMENT or GM_ERR_BUFFER_TOO_SMALL otherwise
+ */
+GM_NODISCARD int gm_oid_to_hex(const gm_oid_t *oid, char *out, size_t out_size);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* GITMIND_UTIL_OID_H */

core/src/app/cache/cache_rebuild_service.c

@@ -3,8 +3,6 @@
 
 #include "gitmind/cache/internal/rebuild_service.h"
 
-#include <git2/oid.h>
-
 #include <limits.h>
 #include <stdbool.h>
 #include <stdint.h>
@@ -29,6 +27,7 @@
 #include "gitmind/security/memory.h"
 #include "gitmind/security/string.h"
 #include "gitmind/util/memory.h"
+#include "gitmind/util/oid.h"
 #include "gitmind/util/ref.h"
 
 #define MAX_SHARD_PATH 32
@@ -121,8 +120,11 @@ static void get_oid_prefix(const gm_oid_t *oid, char *prefix, int bits) {
         return;
     }
 
-    char hex[GM_OID_HEX_CHARS];
-    git_oid_fmt(hex, oid); /* not null-terminated */
+    char hex[GM_OID_HEX_CHARS + 1] = {0};
+    if (gm_oid_to_hex(oid, hex, sizeof(hex)) != GM_OK) {
+        prefix[0] = '\0';
+        return;
+    }
     if (chars > GM_OID_HEX_CHARS) {
         chars = GM_OID_HEX_CHARS;
     }
@@ -135,11 +137,7 @@ static void get_oid_prefix(const gm_oid_t *oid, char *prefix, int bits) {
 }
 
 static int oid_to_hex(const gm_oid_t *oid, char *out, size_t out_size) {
-    if (out_size < SHA_HEX_SIZE) {
-        return GM_ERR_INVALID_ARGUMENT;
-    }
-    (void)git_oid_tostr(out, out_size, oid);
-    return GM_OK;
+    return gm_oid_to_hex(oid, out, out_size);
 }
 
 typedef struct {

core/src/cache/query.c

@@ -18,6 +18,7 @@
 #include "gitmind/security/string.h"
 #include "gitmind/util/ref.h"
 #include "gitmind/util/memory.h"
+#include "gitmind/util/oid.h"
 #include "gitmind/constants_internal.h"
 
 /* Constants */
@@ -40,17 +41,6 @@ static int gm_hex_value(char c) {
     return -1;
 }
 
-static void gm_raw_to_hex(const uint8_t *raw,
-                          char out_hex[GM_OID_HEX_CHARS + 1]) {
-    static const char kHexDigits[] = "0123456789abcdef";
-    for (size_t i = 0; i < GM_OID_RAWSZ; ++i) {
-        unsigned byte = raw[i];
-        out_hex[i * 2] = kHexDigits[(byte >> 4) & 0xF];
-        out_hex[i * 2 + 1] = kHexDigits[byte & 0xF];
-    }
-    out_hex[GM_OID_HEX_CHARS] = '\0';
-}
-
 static int gm_hex_to_raw(const char *hex, uint8_t *out_raw, size_t raw_size) {
     if (hex == NULL || out_raw == NULL) {
         return GM_ERR_INVALID_ARGUMENT;
@@ -84,14 +74,25 @@ static bool gm_oid_equal(const gm_oid_t *a, const gm_oid_t *b) {
 /* Get SHA prefix for sharding */
 static void get_sha_prefix(const uint8_t *sha, char *prefix, int bits) {
     int chars = (bits + 3) / BITS_PER_HEX_CHAR; /* Round up to hex chars */
-    if (chars <= 0) { prefix[0] = '\0'; return; }
-    git_oid tmp;
-    git_oid_fromraw(&tmp, sha);
-    char hex[GM_OID_HEX_CHARS];
-    git_oid_fmt(hex, &tmp); /* not null-terminated */
-    if (chars > GM_OID_HEX_CHARS) chars = GM_OID_HEX_CHARS;
-    /* Copy requested prefix and terminate */
-    for (int i = 0; i < chars; i++) prefix[i] = hex[i];
+    if (chars <= 0) {
+        prefix[0] = '\0';
+        return;
+    }
+
+    char hex[GM_OID_HEX_CHARS + 1] = {0};
+    if (gm_bytes_to_hex(sha, GM_OID_RAWSZ, hex, sizeof(hex)) != GM_OK) {
+        prefix[0] = '\0';
+        return;
+    }
+    if (chars > GM_OID_HEX_CHARS) {
+        chars = GM_OID_HEX_CHARS;
+    }
+    if (chars >= SHA_PREFIX_BUFFER_SIZE) {
+        chars = SHA_PREFIX_BUFFER_SIZE - 1;
+    }
+    for (int i = 0; i < chars; ++i) {
+        prefix[i] = hex[i];
+    }
     prefix[chars] = '\0';
 }
 
@@ -259,7 +260,9 @@ static int load_bitmap_from_cache(const gm_git_repository_port_t *port,
     get_sha_prefix(sha, prefix, GM_CACHE_SHARD_BITS);
 
     /* Convert SHA to hex */
-    gm_raw_to_hex(sha, sha_hex);
+    if (gm_bytes_to_hex(sha, GM_OID_RAWSZ, sha_hex, sizeof(sha_hex)) != GM_OK) {
+        return GM_ERR_BUFFER_TOO_SMALL;
+    }
 
     /* Build path: prefix/sha.suffix */
     {