Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Oct 27, 2026
Google reviews admob.readonly against the privacy policy, so the policy has to name it before the scope is submitted. It says one permission is asked for, for the service chosen, what is read from AdMob (its account list and one earnings report), and that an AdMob figure is public to the millionth of a dollar.
Lin1er
force-pushed
the
docs/admob-consent
branch
from
October 31, 2026 05:11
f12b0ed to
e1a44e5
Compare
Lin1er
marked this pull request as ready for review
October 31, 2026 05:11
Collaborator
Author
|
Rebased on @AncungAulia — the wording is still yours to change. @Lexirieru — this has to be live before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #98: the legal pages half. The OAuth client half is in the Google Cloud console, and @Lin1er is doing it.
Why now. The consent screen is published (#86). Google reviews a new sensitive scope against the privacy policy, so
/privacyhas to nameadmob.readonlybefore the scope is submitted for verification.@AncungAulia, this is your half of #98. I drafted it so it is not on the critical path. The wording is yours to change: push to this branch or tell me what to change.
What changed (
landing-page/src/content/legal.ts)adsense.readonlyadsense.readonlyfor AdSense andadmob.readonlyfor AdMoblegal.test.tsnow expects both scopes, in that order, matching the strings inbe/(be/src/admob/request.tsis on #100), and the "one permission only" sentence.Every claim matches what the AdMob relay on #100 and the front end on #104 do. #104 asks Google only for the chosen source's scope.
Merging
This PR is
out-of-sow(#90), so it waits for @Lexirieru's go on #90 like #100, #101 and #104. If AdMob ships after 2026-11-08 instead, this merges with it.One caveat: if the scope is added to the published consent screen before this is live, Google's verification can ask for a policy that names it.
Checked
next buildpasses, and/privacyand/termsare static.