Skip to content

docs(#98): the privacy policy and terms cover AdMob, the second scope - #105

Open
Lin1er wants to merge 1 commit into
mainfrom
docs/admob-consent
Open

Lin1er wants to merge 1 commit into
mainfrom
docs/admob-consent

Conversation

@Lin1er

@Lin1er Lin1er commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Part of #98: the legal pages half. The OAuth client half is in the Google Cloud console, and @Lin1er is doing it.

Why now. The consent screen is published (#86). Google reviews a new sensitive scope against the privacy policy, so /privacy has to name admob.readonly before the scope is submitted for verification.

@AncungAulia, this is your half of #98. I drafted it so it is not on the critical path. The wording is yours to change: push to this branch or tell me what to change.

What changed (landing-page/src/content/legal.ts)

Where Before Now
Intro "prove their AdSense revenue" "prove their AdSense or AdMob revenue"
What we ask Google for One permission, adsense.readonly "One permission only, for the service you choose to prove", then adsense.readonly for AdSense and admob.readonly for AdMob
What we read The AdSense account list and its state, plus one report The same for AdSense. For AdMob, the AdMob account list. The one report is the same: estimated earnings in USD over the last three complete months
What becomes public "your AdSense publisher ID", "the revenue figure, to the cent" "your AdSense or AdMob publisher ID", "to the cent for AdSense and to the millionth of a dollar for AdMob" (the signed AdMob figure is micros, #93)
Not revealed "your sites" "your sites, your apps"
Terms "Your AdSense account" "Your AdSense or AdMob account"
Effective date 23 October 2026 27 October 2026

legal.test.ts now expects both scopes, in that order, matching the strings in be/ (be/src/admob/request.ts is on #100), and the "one permission only" sentence.

Every claim matches what the AdMob relay on #100 and the front end on #104 do. #104 asks Google only for the chosen source's scope.

Merging

This PR is out-of-sow (#90), so it waits for @Lexirieru's go on #90 like #100, #101 and #104. If AdMob ships after 2026-11-08 instead, this merges with it.

One caveat: if the scope is added to the published consent screen before this is live, Google's verification can ask for a policy that names it.

Checked

  • Landing lint and typecheck are clean. 180/180 tests pass, including the copy rules.
  • next build passes, and /privacy and /terms are static.

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
forepay Ready Ready Preview Oct 31, 2026 5:11am UTC
1 Skipped Deployment
Project Deployment Actions Updated
forepay-vue5 Skipped Skipped Oct 31, 2026 5:11am UTC

Google reviews admob.readonly against the privacy policy, so the policy has to
name it before the scope is submitted. It says one permission is asked for, for
the service chosen, what is read from AdMob (its account list and one earnings
report), and that an AdMob figure is public to the millionth of a dollar.
@Lin1er
Lin1er force-pushed the docs/admob-consent branch from f12b0ed to e1a44e5 Compare October 31, 2026 05:11
@Lin1er
Lin1er marked this pull request as ready for review October 31, 2026 05:11
@Lin1er

Lin1er commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased on main (0138a4f) and marked ready. #100, #101 and #104 are merged, so the AdMob scope this page describes is live in the relay and the front end. Landing tests (180/180), lint and typecheck pass locally.

@AncungAulia — the wording is still yours to change. @Lexirieru — this has to be live before admob.readonly goes to Google for verification, because the reviewer checks /privacy for the scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant