fix(ci): drop self-cancelling concurrency from reusables (#2307) - #5
Merged
Merged
Conversation
…307)
In a reusable workflow github.workflow resolves to the CALLER's name, so a
top-level concurrency group of ${{ github.workflow }}-${{ github.ref }} with
cancel-in-progress matches the caller's own group → the reusable cancels its
own caller → 0 jobs, failure. Latent since #2293; surfaced by theatron, the
first caller-adopter. The caller workflow owns concurrency; reusables must not
redeclare the colliding group. Refs #2307.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusables declared concurrency group
${{ github.workflow }}-${{ github.ref }}(=caller's group in reusable context) with cancel-in-progress → self-cancel → 0 jobs. Blocked ALL canonical-CI caller adoption since #2293 (theatron #149 caught it; security survived via PR-number key). Caller owns concurrency; dropped from gate-attestation/no-ai-attribution/dependabot-auto-merge/codeql. Refs forkwright/kanon#2307.