Repository navigation
fix: audit media correctness, resource lifetimes and update integrity - #4
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This audit fixes capture/audio teardown lifetimes, packed PCM conversion, bounded mixer work, codec-family fallback, manual-recording B-frame timestamps and failed-output handling. It also preserves collection membership on catalog failure, serializes bookmark allocation, fixes catalog migration/cache invalidation, bounds RPC and Stream Deck state, and requires updater integrity metadata with safe ZIP paths.
The report and 239-file inventory are in docs/audit/2026-10-08.md and docs/audit/file-inventory.md. They list corrected findings and unresolved work, including component-wide update rollback, remaining UI catalog writes, synchronous recording I/O and Windows runtime validation.
Validation: strict native media/encoder/mixer/storage/PCM/socket regressions, six Rust tests, Windows-target updater module check, both frontend TypeScript and Vite builds, Stream Deck socket integration, eight packaging verifier cases and repository text/diff checks passed locally. Linux shims do not validate WGC/WASAPI or clean Windows installation. GitHub Actions checks are attached to this PR.
Stacked on #3 to keep packaging changes out of the audit diff. Review/merge order: packaging, code audit, comment cleanup. No merge or release is performed.