fix: Keep bubble menu open while color picker popover is active - #695
Open
stravo1 wants to merge 2 commits into
Open
fix: Keep bubble menu open while color picker popover is active#695stravo1 wants to merge 2 commits into
stravo1 wants to merge 2 commits into
Conversation
The bubble menu's default shouldShow hides it once focus leaves its DOM subtree, but the color picker popover is teleported to <body>, so opening it closed the menu. Track the popover's open state and factor it into a custom shouldShow check. Also settle the autocomplete's fixed-position recalculation on the next animation frame instead of just nextTick, since layout can still be mid-flight when nextTick resolves.
Contributor
Confidence Score: 5/5Safe to merge — the change is isolated to bubble-menu visibility and autocomplete positioning with no effect on data or state persistence. All three files make narrow, well-scoped changes. The custom shouldShow faithfully mirrors the default TipTap logic and adds two clearly bounded overrides. The nextTick → rAF deferral is a standard pattern for post-layout reads. Files Needing Attention: No files require special attention. Reviews (2): Last reviewed commit: "Merge branch 'develop' into fix-bubble-m..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #695 +/- ##
========================================
Coverage 57.59% 57.59%
========================================
Files 35 35
Lines 4271 4271
========================================
Hits 2460 2460
Misses 1811 1811 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # frontend/src/components/Controls/Autocomplete.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bubble menu's default shouldShow hides it once focus leaves its DOM subtree, but the color picker popover is teleported to , so opening it closed the menu. This in turn also transported the Popover to the screen's edge. Now we track the popover's open state and factor it into a custom shouldShow check.
Also settle the Autocomplete's fixed-position recalculation on the next animation frame instead of just nextTick, since layout can still be mid-flight when nextTick resolves.
Before:
Screen.Recording.2026-07-25.at.2.48.57.AM.mp4
After:
Screen.Recording.2026-07-25.at.2.49.39.AM.mp4