fix: keep newly created text block editable through the creating click - #697
Open
stravo1 wants to merge 2 commits into
Open
fix: keep newly created text block editable through the creating click#697stravo1 wants to merge 2 commits into
stravo1 wants to merge 2 commits into
Conversation
Selecting synchronously in makeBlockEditable prevents the block's own deferred selectBlock call from clearing editableBlock right after it's set. TextBlock also swallows the one spurious click-outside event that the creating click's native "click" triggers before the block has rendered, and catches up the focus/edit-mode entry that the isEditable watch missed because the editor didn't exist yet at mount time.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "fix: Respect select=false for text child..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #697 +/- ##
===========================================
+ Coverage 56.88% 57.59% +0.70%
===========================================
Files 35 35
Lines 4217 4271 +54
===========================================
+ Hits 2399 2460 +61
+ Misses 1818 1811 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stravo1
changed the title
addChild called makeBlockEditable() for text children even when a caller passed select=false, so component-instance sync and drag-to-a-new-parent reordering could select and focus a text block with no user interaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting synchronously in makeBlockEditable prevents the block's own deferred selectBlock call from clearing editableBlock right after it's set. TextBlock also swallows the one spurious click-outside event that the creating click's native "click" triggers before the block has rendered, and catches up the focus/edit-mode entry that the isEditable watch missed because the editor didn't exist yet at mount time.
Before:
Screen.Recording.2026-07-28.at.12.20.50.PM.mov
After:
Screen.Recording.2026-07-28.at.12.21.28.PM.mov