Skip to content

fix: keep newly created text block editable through the creating click #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stravo1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: keep newly created text block editable through the creating click #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486679b
fix: Keep newly created text block editable through the creating click
stravo1 Jul 28, 2026
4e835d8
fix: Respect select=false for text children in addChild
stravo1 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions frontend/src/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,10 +584,12 @@ class Block implements BlockOptions {
childBlock.parentBlock = this;
this.children.splice(index, 0, childBlock);
if (select) {
childBlock.selectBlock();
}
if (childBlock.isText()) {
childBlock.makeBlockEditable();
if (childBlock.isText()) {
// makeBlockEditable() selects the block and enters edit mode synchronously.
childBlock.makeBlockEditable();
} else {
childBlock.selectBlock();
}
}

if (childBlock.getStyle("position")) {
Expand Down Expand Up @@ -757,7 +759,9 @@ class Block implements BlockOptions {
}
makeBlockEditable() {
const canvasStore = useCanvasStore();
this.selectBlock();
// canvasStore.selectBlock() runs synchronously here. A deferred call would clear
// editableBlock right after this line sets it.
canvasStore.selectBlock(this, null);
canvasStore.editableBlock = this;
nextTick(() => {
this.getEditor()?.commands.focus("all");
Expand Down
13 changes: 13 additions & 0 deletions frontend/src/components/TextBlock.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ onBeforeMount(() => {
});

let pauseId: PauseId | undefined = undefined;
// The creating click also fires a native click event before the block renders.
// vOnClickOutside reads that as an outside click and ends edit mode. This flag skips it once.
let skipNextClickOutside = false;

watch(
() => isEditable.value,
Expand Down Expand Up @@ -292,6 +295,12 @@ if (!props.preview) {

props.block.setEditor(editor.value);
editor.value?.setEditable(isEditable.value);
// A block can already be editable at mount, before editor.value exists.
// The isEditable watch above then misses the focus call. This catches up now.
if (isEditable.value) {
editor.value?.commands.focus("all");
skipNextClickOutside = true;
}
} else {
destroyEditor();
}
Expand Down Expand Up @@ -319,6 +328,10 @@ const handleEscKey = () => {
};

const handleClickOutside = (e: MouseEvent) => {
if (skipNextClickOutside) {
skipNextClickOutside = false;
return;
}
if ((e.target as HTMLElement).closest(".canvas-container")) {
canvasStore.editableBlock = null;
}
Expand Down
Loading