Repository navigation
fix(media): locate attachments in the original Windows account - #10
Merged
freanocank merged 1 commit intoOct 13, 2026
Merged
Conversation
Owner
|
Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. Attachment lookup now uses the matching original Windows account, and the synthetic routing/document regressions pass. The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the decrypted mirror contains database files, while attachments remain in the original WeChat account. media/openfile currently derive their attachment root from the mirror, so existing documents and media cannot be found there.
Resolve the original account directory by matching the selected mirror account against the original data roots. Fail explicitly when that original directory cannot be uniquely located, then use it for both media export and document lookup. Keep the existing direct-store behavior on the SQLCipher backend.
Validation: five synthetic tests cover matching the correct account among multiple accounts, missing original data, direct-store behavior, media routing, and reading a document present only in the original directory. All five fail on main and pass with this change. Filename-collision handling remains in the separate existing PR #5.
Local validation uses Windows/Python 3.12 and synthetic fixtures. The consistency-checker file and two fingerprint-dependent existing tests were excluded by the local execution policy; no account databases, chat contents or keys are included.
Local branch suite: 86 passed, two tests deselected, consistency-checker file excluded.