Repository navigation
fix(query): resolve sender identity within each message shard - #3
Merged
Merged
Conversation
Owner
|
Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. The cross-shard sender regressions pass in the combined branch. The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query results can swap
[我]and[对方]when the account owner'sName2Id.rowiddiffers between message shards. The query layer previously detected one numeric sender ID and reused it across databases, even though those row IDs are database-local.Resolve sender wxids through each shard's own
Name2Idjoin in read, search (including the compressed-message fallback), recent and summary. Formatting compares the resolved wxid with the account owner and labels unresolved senders[未知]instead of guessing from a numeric ID. System-message labels are unchanged.Validation on macOS / Python 3.12:
python -m pytest -q: 90 passed, 1 skipped, including compressed-message search and unresolved-sender cases.All fixtures are synthetic; no WeChat data or keys are included. The fork CI matrix passed on macOS and Windows with Python 3.10 and 3.13: run 38035160551. The upstream fork-PR workflow still requires maintainer approval.