Repository navigation
fix(contacts): require a unique match before read or export - #4
Merged
Merged
Conversation
Owner
|
Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. Ambiguous names now require an exact contact selection before message reads or export writes. The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a name matches two to five contacts,
read_chat()reads every matched conversation and the export CLI silently selects the first. Only more than five matches were rejected, despite the existing Skill/MCP guidance to ask for a selection.Reject every non-unique match before fetching message contents or opening an output file. Return/display candidate wxids so callers can retry with an exact identifier. The no-match and single-match behavior remains supported.
Validation on macOS / Python 3.12:
python -m pytest -q: 91 passed, 1 skipped.Export-selection fixtures are uncompressed, so they stub only the optional zstd availability gate. Modern timestamps and explicit UTF-8 keep the synthetic exports portable across macOS and Windows.
This PR is independent of the sender-direction fix. It contains only synthetic contact fixtures, without personal chat data or keys. The final fork CI matrix passed on macOS and Windows with Python 3.10 and 3.13: run 38039930827, at commit
80942a0. The upstream fork-PR workflow still requires maintainer approval.