Repository navigation
fix(query): reject invalid day windows and result limits - #8
Merged
freanocank merged 1 commit intoOct 13, 2026
Merged
Conversation
Owner
|
Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. Invalid windows and limits are rejected before database discovery; valid boundaries pass. The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative result limit reaches SQLite as
LIMIT -1, which removes the limit; other invalid limits and day windows produce inconsistent query behavior.Validate windows before database discovery in read, search, recent, system-events, summary and stats. Require positive integer days and integer result limits from 1 to 2000; reject booleans and non-integers with a clear ValueError.
Validation: 54 invalid-input cases verify rejection before any database access, plus three valid limit boundaries. Invalid-input regressions fail on main and the updated suite passes. This changes only window validation.
Local validation uses Windows/Python 3.12 and synthetic fixtures. The consistency-checker file and two fingerprint-dependent existing tests were excluded by the local execution policy; no account databases, chat contents or keys are included.
Local branch suite: 138 passed, two tests deselected, consistency-checker file excluded.