Skip to content

fix(windows): honor relocated WeChat data roots - #9

Merged
freanocank merged 1 commit into
freanocank:mainfrom
Lee-Juntong:fix/windows-data-root
Oct 13, 2026
Merged

freanocank merged 1 commit into
freanocank:mainfrom
Lee-Juntong:fix/windows-data-root

Conversation

@Lee-Juntong

Copy link
Copy Markdown
Contributor

Windows discovery assumes WeChat data lives under Documents/xwechat_files. A user who moved the storage directory cannot reliably use the native extractor, decryptor and query configuration with the same location.

Honor WECHAT_DATA_ROOT consistently in config.py, native message-database discovery and native decryption. The value is the xwechat_files parent directory; expand user/environment variables and preserve the default discovery paths when unset. A configured missing location does not silently fall back to another account. Document the Windows setup.

Validation: three synthetic tests cover a relocated path containing spaces and Unicode, a missing override, and unchanged defaults. The two override regressions fail on main and the updated suite passes. This fixes discovery; successful live native key capture remains unverified.

Local validation uses Windows/Python 3.12 and synthetic fixtures. The consistency-checker file and two fingerprint-dependent existing tests were excluded by the local execution policy; no account databases, chat contents or keys are included.

Local branch suite: 84 passed, two tests deselected, consistency-checker file excluded.

@freanocank
freanocank merged commit de07354 into freanocank:main Oct 13, 2026
1 check passed
@freanocank

Copy link
Copy Markdown
Owner

Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. Relocated-directory regressions pass across query, extraction and decryption discovery. Live native WeChat key capture remains a separate validation boundary.

The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants