fix(watch): fold sentinel '-' into the empty session-id path - #857
Open
apstndb wants to merge 3 commits into
Open
fix(watch): fold sentinel '-' into the empty session-id path#857apstndb wants to merge 3 commits into
apstndb wants to merge 3 commits into
Conversation
…#855) Callers still pass "${GROK_SESSION_ID:--}" from fujibee#477, but watch.sh stopped folding the literal dash, so monitor re-eval wrote watch.-.pid. Restore the one-line fold and the bats case that locked it. Co-authored-by: Cursor <cursoragent@cursor.com>
…old case The restored bats locks the fujibee#477 fold, not the later regression ticket. Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
Non-last `! cmd` is silent on bash 3.2, so the new fold case raised the enforced-assertions baseline. refute fails the test on every platform. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #855.
Restores the #477 one-line fold of sentinel
-inwatch.sh, and the bats case that locked it. Callers that pass"${GROK_SESSION_ID:--}"are unchanged. Problem, repro, and why this is not a caller fix are on the issue.Independently mergeable. #858 no longer contains these commits (unstacked). Cursor monitor still needs this fold at runtime (
"${CURSOR_CONVERSATION_ID:--}"), so please land this before #858. #858 stays a draft until then.Test plan
bats tests/test_watch.bats --filter "sentinel '-' session_id".github/scripts/check-enforced-assertions.shat baseline