docs: document GCP project for hosted mint#2464
Conversation
Record where the default public mint Cloud Function runs so platform operators and SREs can find it without inferring from gcloud config. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Site previewPreview: https://e2a61287-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 8:26 AM UTC · Completed 8:34 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsHigh
Low
Labels: PR modifies mint service documentation under docs/guides/infrastructure/. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| The fullsend team operates a public hosted mint service. If your organization is enrolled, you can use it directly without deploying your own: | ||
| The fullsend team operates a public hosted mint service. If your organization is enrolled, you can use it directly without deploying your own. | ||
|
|
||
| **Platform GCP project:** The hosted mint currently runs in GCP project `it-gcp-konflux-dev-fullsend` (project number `855403973659`, region `us-central1`). |
There was a problem hiding this comment.
[high] sensitive data exposure
The diff adds the GCP project name it-gcp-konflux-dev-fullsend and project number 855403973659 to a committed documentation file. The repository's AGENTS.md policy explicitly prohibits committing GCP project names, listing them as sensitive data alongside tokens and API keys.
Suggested fix: Remove the GCP project name and project number from the documentation. If operators need to discover the hosted mint's GCP project, reference an environment variable or internal configuration source rather than hard-coding the value in version-controlled files.
|
|
||
| **Platform GCP project:** The hosted mint currently runs in GCP project `it-gcp-konflux-dev-fullsend` (project number `855403973659`, region `us-central1`). | ||
|
|
||
| **Mint URL:** |
There was a problem hiding this comment.
[low] structural-consistency
The label 'Mint URL:' followed by an empty line and then a code block creates a terse introduction compared to other code block introductions in the file, which typically use full prose sentences.
Suggested fix: Either remove the empty line between 'Mint URL:' and the code block, or integrate the URL into flowing prose.
fullsend-ai-review
Bot
added
component/mint
rh-hemartin
left a comment
rh-hemartin
left a comment
There was a problem hiding this comment.
Not sure why this is a draft, but LGTM. Which stuff do you want to add in addition to current changes?
All the bots jumped on this and said this is against our stated policy and might be a security risk, so I kept as draft for now. |
2 participants
Summary
it-gcp-konflux-dev-fullsend) and region where the fullsend team hosts the default public mint Cloud FunctionTest plan
Made with Cursor