-
Notifications
You must be signed in to change notification settings - Fork 55
docs: document GCP project for hosted mint #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,11 @@ This guide covers deploying and managing the fullsend token mint Cloud Function. | |
|
|
||
| ## Hosted mint | ||
|
|
||
| The fullsend team operates a public hosted mint service. If your organization is enrolled, you can use it directly without deploying your own: | ||
| The fullsend team operates a public hosted mint service. If your organization is enrolled, you can use it directly without deploying your own. | ||
|
|
||
| **Platform GCP project:** The hosted mint currently runs in GCP project `it-gcp-konflux-dev-fullsend` (project number `855403973659`, region `us-central1`). | ||
|
|
||
| **Mint URL:** | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] structural-consistency The label 'Mint URL:' followed by an empty line and then a code block creates a terse introduction compared to other code block introductions in the file, which typically use full prose sentences. Suggested fix: Either remove the empty line between 'Mint URL:' and the code block, or integrate the URL into flowing prose. |
||
|
|
||
| ``` | ||
| https://fullsend-mint-gljhbkcloq-uc.a.run.app | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] sensitive data exposure
The diff adds the GCP project name
it-gcp-konflux-dev-fullsendand project number855403973659to a committed documentation file. The repository's AGENTS.md policy explicitly prohibits committing GCP project names, listing them as sensitive data alongside tokens and API keys.Suggested fix: Remove the GCP project name and project number from the documentation. If operators need to discover the hosted mint's GCP project, reference an environment variable or internal configuration source rather than hard-coding the value in version-controlled files.