Repository navigation
Custom MAX_DATA_LEN - #15
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes MAX_DATA_LEN configurable (overrideable at compile time) and normalizes formatting/line endings across tests, examples, docs, and CI files.
Changes:
- Allow overriding
MAX_DATA_LENvia preprocessor (#ifndef MAX_DATA_LEN ... #endif). - Reformat/normalize line endings across tests, examples, docs, and GitHub workflows.
- No intended behavioral changes in tests/examples beyond the above (but see review comments for issues found in touched files).
Reviewed changes
Copilot reviewed 1 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/SerialMuxProtCommon.hpp |
Makes MAX_DATA_LEN overrideable (core purpose of PR). |
test/common/TestStream.h |
Formatting changes; touched code includes readBytes() implementation used by tests. |
test/test_SerialMuxProt/test_SerialMuxProt.cpp |
Formatting changes; test callback declaration/docs touched. |
test/common/Stream.h |
Formatting/line-ending normalization only. |
test/common/Print.h |
Formatting/line-ending normalization only. |
examples/ServerA/main.cpp |
Formatting/line-ending normalization only. |
examples/ServerB/main.cpp |
Formatting/line-ending normalization only. |
examples/SerialMuxChannels.h |
Formatting/line-ending normalization only. |
examples/README.md |
Formatting/line-ending normalization only. |
doc/uml/SyncSequence.puml |
Formatting/line-ending normalization only. |
doc/uml/SubscribeSequence.puml |
Formatting/line-ending normalization only. |
.github/workflows/release.yml |
Formatting; workflow display name touched. |
.github/workflows/ci.yml |
Formatting/line-ending normalization only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@gabryelreyes I've opened a new pull request, #16, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…load) Co-authored-by: gabryelreyes <66941456+gabryelreyes@users.noreply.github.com>
Co-authored-by: gabryelreyes <66941456+gabryelreyes@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add static_assert to guard MAX_DATA_LEN against control channel underflow
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DESCRIPTION | ||
| *******************************************************************************/ | ||
| /** | ||
| * @brief Stream Module for uint testing |
There was a problem hiding this comment.
The Doxygen brief says "uint testing" which reads like a typo (it should likely be "unit testing"). Please fix the wording to avoid confusion in generated docs.
Suggested change
| * @brief Stream Module for uint testing | |
| * @brief Stream Module for unit testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.