Repository navigation
Add static_assert to guard MAX_DATA_LEN against control channel underflow - #16
Merged
Merged
Conversation
Merged
…load) Co-authored-by: gabryelreyes <66941456+gabryelreyes@users.noreply.github.com>
Co-authored-by: gabryelreyes <66941456+gabryelreyes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on custom MAX_DATA_LEN implementation
Add static_assert to guard MAX_DATA_LEN against control channel underflow
Feb 27, 2026
gabryelreyes
marked this pull request as ready for review
February 27, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MAX_DATA_LENis overridden by a consumer, it must be at least as large asControlChannelPayload(16 bytes) or channel 0 send/receive will overflow the payload buffer. Previously there was no enforcement of this constraint.Changes
src/SerialMuxProtCommon.hpp: Addedstatic_assertafter theControlChannelPayloadtypedef to enforce the minimum size at compile time:Defining
MAX_DATA_LENbelow 16 now produces a clear compiler error indicating the failing size comparison, e.g.the comparison reduces to '(4 >= 16)'.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.