Skip to content

Add static_assert to guard MAX_DATA_LEN against control channel underflow #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabryelreyes merged 3 commits into from
Feb 27, 2026
Merged

Add static_assert to guard MAX_DATA_LEN against control channel underflow #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2126401
Initial plan
Copilot Feb 27, 2026
a875b80
Add static_assert to enforce MAX_DATA_LEN >= sizeof(ControlChannelPay…
Copilot Feb 27, 2026
2975a14
Remove accidentally committed build artifacts from tracking
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
.pio
.vscode
null.o
_codeql_detected_source_root
3 changes: 3 additions & 0 deletions src/SerialMuxProtCommon.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,5 +186,8 @@ typedef struct _ControlChannelPayload
char channelName[CHANNEL_NAME_MAX_LEN] = {0U}; /**< Channel Name */
} __attribute__((packed)) ControlChannelPayload; /**< ControlChannelPayload */

static_assert(MAX_DATA_LEN >= sizeof(ControlChannelPayload),
"MAX_DATA_LEN must be >= sizeof(ControlChannelPayload) to avoid buffer overflows on control channel.");

#endif /* SERIALMUXPROT_COMMON_H_ */
/** @} */