Use upstream access control headers - #386
Conversation
| #add_header Access-Control-Allow-Origin "http://registry.intermine.org"; | ||
| if ($http_origin ~ "^https?://(covid19\.galaxyproject\.org|registry\.intermine\.org)$") { |
There was a problem hiding this comment.
Probably not, but there are additional directives I'm not setting ... we can try this on test first.
There was a problem hiding this comment.
(i mean Expose-Headers and Allow-Headers)
There was a problem hiding this comment.
we can try this on test first.
sounds good. (i've linked this thread from the related EU playbook change, so, they'll surely check here for the conclusion.)
|
This should also work with a second proxy (traefik) load-balancing multiple servers running nginx right? |
|
As long as the upstream doesn't drop any response headers it should work, yes. |
natefoo
left a comment
natefoo
left a comment
There was a problem hiding this comment.
LGTM and much nicer than what we were doing.
|
Can anyone please confirm that we can remove the |
|
Can anyone please confirm that this works and we can remove the CORS from our config? |
|
How can we tell ? I know avivator works but I don't know why those other headers were set. You can try this yourself and report if anything doesn't work. |
5 participants
No description provided.