Unblock Gloas submissions through the existing bid-submission wire shape - #514
Open
0w3n-d wants to merge 7 commits into
Open
Unblock Gloas submissions through the existing bid-submission wire shape#5140w3n-d wants to merge 7 commits into
0w3n-d wants to merge 7 commits into
Conversation
…dcast it to beacon nodes
helix's ExecutionPayload/SignedBidSubmission is its own bounded-list builder<->relay wire shape, shared unchanged across Bellatrix-Fulu; it is not a mirror of the real per-fork consensus SSZ types. Route the Gloas fork through the same decode path Fulu already uses instead of erroring, and add conversion functions producing the real, progressive-list Gloas consensus types (ExecutionPayloadGloas, ExecutionRequestsGloas) for use at the outbound bid/envelope boundary. block_access_list, builder_deposits, and builder_exits are left empty (TODO(gloas): EIP-7928/EIP-8282, no producer path yet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #489 (step 5 of 6, reordered ahead of the original step 5 -- see issue update)
What this PR does
helix's
ExecutionPayload/SignedBidSubmission(crates/types/src/bid_submission.rs)is its own bounded-list builder<->relay wire shape, shared unchanged across
Bellatrix-Fulu -- not a mirror of the real per-fork consensus SSZ types. The
ForkName::Gloasarms inhydration.rs/execution_payload.rscurrently hard-error,which blocks Gloas-fork submissions from decoding at all.
ForkName::Gloasthrough the same decode pathForkName::Fulualreadyuses, in the 4 places that previously errored.
ExecutionPayload::to_lighthouse_gloas_payloadandexecution_requests_to_gloas, converting helix's bounded-list submission datainto the real, progressive-list Gloas consensus types
(
ExecutionPayloadGloas/ExecutionRequestsGloas), for use at the outboundbid/envelope boundary.
What this PR deliberately does NOT do
getExecutionPayloadBidorsubmitSignedBeaconBlockyet -- that's the next step.block_access_list(EIP-7928) orbuilder_deposits/builder_exits(EIP-8282); left empty with aTODO(gloas)marker sincethere's no producer path for any of these yet.
Tests
Written before implementation, per this repo's workflow:
the existing Fulu round-trip tests.
withdrawals/deposits/withdrawals/consolidations preserved, new fields
defaulted,
slot_numberset correctly).Reviewer checklist
lint,unit-test) is greentouched, no obviously-wrong code the tests happen not to cover