Fix accept visible images#779
Conversation
commit: |
✅ Component tests succeed
|
✅ E2E tests succeed
|
|
|
||
| return visibleResultIds.flatMap(resultId => { | ||
| return visibleResultIds.flatMap((resultId) => { | ||
| const suitePath = resultsById[resultId].suitePath.join('/'); |
There was a problem hiding this comment.
This .join("/") looks "magic"
expandedTreeNodesById, looking at its name, wants Id as key
We need suiteId
SuiteId can be derived from result like this:
const result = state.tree.results.byId[resultId];
const browser = state.tree.browsers.byId[result.parentId];
const suiteId = browser.parentId;
// const suite = state.tree.suites.byId[suiteId];There was a problem hiding this comment.
No, in expandedTreeNodesById we have object like this (see above), it is entityId from useList hook (from gravity-ui)
There was a problem hiding this comment.
A little helper to get "treeNodeId" from result would be nice, so we would call "getTreeNodeId" everywhere we need, without having to remember "its constructed as suitePath.join('/')"
|
|
||
| export const getVisibleImages = createSelector( | ||
| getVisibleBrowserIds, getBrowsers, getResults, getImages, getIsStaticImageAccepterEnabled, getIsGui, | ||
| (state) => state.ui.suitesPage.expandedTreeNodesById, |
There was a problem hiding this comment.
Sinse other arguments are named functions, i think we should pull this (state) => state.ui.suitesPage.expandedTreeNodesById into named function (like getExpandedTreeNodesById)
cb3d589 to
699dc69
Compare
dc5e1de to
3ff0b98
Compare
2 participants
Now, if image not expanded (
check 4on screenshot) it will not be accepted