Skip to content

Fix accept visible images #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonic16x merged 3 commits into from
Jul 14, 2026
Merged

Fix accept visible images #779

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a24a3de
fix: accept visible images
Jul 9, 2026
785160d
fix: state function
Jul 14, 2026
3ff0b98
fix: helper
Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/static/modules/selectors/tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,20 @@ export const getSelectedBrowserIds = createSelector(
}
);

const getAcceptableOrRevertableImages = (browserIds, browsersById, resultsById, imagesById, isStaticImageAccepterEnabled, gui) => {
const getExpandedTreeNodesById = (state) => (state.ui.suitesPage.expandedTreeNodesById);
const getTreeEntityId = (result) => result.suitePath.join('/');

const getAcceptableOrRevertableImages = (
browserIds, browsersById, resultsById, imagesById, isStaticImageAccepterEnabled, gui, expandedTreeNodesById
) => {
const visibleResultIds = browserIds.map(browserId => last(browsersById[browserId].resultIds));

return visibleResultIds.flatMap(resultId => {
return visibleResultIds.flatMap((resultId) => {
const suitePath = getTreeEntityId(resultsById[resultId]);
if (expandedTreeNodesById && !expandedTreeNodesById[suitePath]) {
return [];
}

return resultsById[resultId].imageIds
.map(imageId => imagesById[imageId])
.filter(image => isAcceptable(image) || isScreenRevertable({
Expand All @@ -209,6 +219,7 @@ const getAcceptableOrRevertableImages = (browserIds, browsersById, resultsById,

export const getVisibleImages = createSelector(
getVisibleBrowserIds, getBrowsers, getResults, getImages, getIsStaticImageAccepterEnabled, getIsGui,
getExpandedTreeNodesById,
getAcceptableOrRevertableImages
);

Expand Down
Loading