Repository navigation
Conversation
Member
Author
|
I'd like to test this locally a bit more before merging. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent failures during parallel OWL model imports in the Minerva CLI by replacing non-thread-safe shared collections used inside parallelStream() pipelines, aligning with the ClassCastException reported in #572.
Changes:
- Replace a shared
HashSetused during--import-owl-modelswith a concurrent key-set to make parallel duplicate tracking thread-safe. - Replace
HashMap-based duplicate tracking in--validate-go-camswith a concurrent map and useputIfAbsentto detect duplicate IRIs safely in parallel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (i.isDirectory()) { | ||
| LOGGER.info("Loading models from " + i.getAbsolutePath()); | ||
| Set<String> model_iris = new HashSet<String>(); | ||
| FileUtils.listFiles(i, null, true).parallelStream().parallel().forEach(file -> { |
Comment on lines
+966
to
+969
| String existingFile = modelid_filename.putIfAbsent(modeluri, file.getName()); | ||
| if (existingFile != null) { | ||
| LOGGER.error("Multiple models with same IRI: " + modeluri + " file: " + file + " file: " + existingFile); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #572.