test(fees): [ISSUE REPRO] exact-zero internal key falls through - #48
Closed
MuncleUscles wants to merge 1 commit into
Closed
MuncleUscles wants to merge 1 commit into
MuncleUscles wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pin the consensus candidate rule that an internal exact allocation stays present at zero remaining budget. Cover call and deploy emission, phase precedence, and the funded wildcard control. These tests intentionally fail until the executor stops skipping zero-budget internal keys.
MuncleUscles
force-pushed
the
pr/v0.3/handoff/zero-exact-allocation-261001
branch
from
October 2, 2026 10:44
389db9d to
dd98d66
Compare
Member
|
robo-kp2pml30: carried over to genlayerlabs/genvm-manager#57 — these tests, with the fix that makes them pass, land in executor commits 3cd91d2 and 49aa574, gitlinked by manager commit genlayerlabs/genvm-manager@072d9ea (PR head e4252e5). Closing in favor of genlayerlabs/genvm-manager#57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executor mirror of GenVM manager #55, owned by Kira under GVM-365.
This is the same signed executor commit
dd98d661c7ba6afe2ea758b95be2761fce2e706dpinned by the manager PR, rebased onto merged executor #49 (7e0936a125f917a8071b66add10dd555c2a07c8f). It changes only three existing tests to assert that a zero-remaining internal exact allocation shadows a funded wildcard. The three tests fail on current production matching because it selects the wildcard or emits successfully. Five external controls and six positive internal controls pass;cargo fmt --checkand diff checks pass.The manager PR remains the authoritative handoff and merge unit. This mirror is not intended for independent landing. The merged zero-declared-budget fix from executor #49 remains in the parent commit; this PR addresses the distinct exact-allocation selection rule.