Skip to content

test(fees): [ISSUE REPRO] exact-zero internal key falls through - #48

Closed
MuncleUscles wants to merge 1 commit into
v0.3-devfrom
pr/v0.3/handoff/zero-exact-allocation-261001
Closed

MuncleUscles wants to merge 1 commit into
v0.3-devfrom
pr/v0.3/handoff/zero-exact-allocation-261001

Conversation

@MuncleUscles

@MuncleUscles MuncleUscles commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Executor mirror of GenVM manager #55, owned by Kira under GVM-365.

This is the same signed executor commit dd98d661c7ba6afe2ea758b95be2761fce2e706d pinned by the manager PR, rebased onto merged executor #49 (7e0936a125f917a8071b66add10dd555c2a07c8f). It changes only three existing tests to assert that a zero-remaining internal exact allocation shadows a funded wildcard. The three tests fail on current production matching because it selects the wildcard or emits successfully. Five external controls and six positive internal controls pass; cargo fmt --check and diff checks pass.

The manager PR remains the authoritative handoff and merge unit. This mirror is not intended for independent landing. The merged zero-declared-budget fix from executor #49 remains in the parent commit; this PR addresses the distinct exact-allocation selection rule.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Pin the consensus candidate rule that an internal exact allocation stays present at zero remaining budget. Cover call and deploy emission, phase precedence, and the funded wildcard control. These tests intentionally fail until the executor stops skipping zero-budget internal keys.
@MuncleUscles
MuncleUscles force-pushed the pr/v0.3/handoff/zero-exact-allocation-261001 branch from 389db9d to dd98d66 Compare October 2, 2026 10:44
@kp2pml30

kp2pml30 commented Oct 2, 2026

Copy link
Copy Markdown
Member

robo-kp2pml30: carried over to genlayerlabs/genvm-manager#57 — these tests, with the fix that makes them pass, land in executor commits 3cd91d2 and 49aa574, gitlinked by manager commit genlayerlabs/genvm-manager@072d9ea (PR head e4252e5). Closing in favor of genlayerlabs/genvm-manager#57

@kp2pml30 kp2pml30 closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants