test(fees): [ISSUE REPRO] exact-zero internal key falls through - #55
Draft
MuncleUscles wants to merge 1 commit into
Draft
MuncleUscles wants to merge 1 commit into
MuncleUscles wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GenVM PR actionsTick a box to run it (the box unticks itself when handled). Actions only run while the PR has the
Commands
|
Linked executor PR(s)executor: genlayerlabs/genvm-executor#48 (v0.3) |
Advance the v0.3 executor gitlink to the focused expected-red allocation tests. The executor succeeds using a wildcard where the consensus candidate selects a zero-remaining exact key and rejects the emission. This manager layer is a draft handoff for the matcher correction.
MuncleUscles
force-pushed
the
handoff/zero-exact-allocation-261001
branch
from
October 1, 2026 13:40
43b1468 to
db03fc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery context
Depends-On: genlayerlabs/genlayer-consensus#1709
GenVM ticket: GVM-365 (Kira). This manager PR pins the v0.3 executor test commit, mirrored in genvm-executor #48. The repository provision workflow hit an executor PAT HTTP 403, so the exact mirror branch and PR were created through host Git/SSH and GitHub CLI. The manager PR remains the authoritative merge unit.
Problem and outcome
Consensus #1709 resolves internal message allocation keys by presence. An exact key whose remaining budget is zero still shadows a funded call-key wildcard. The emission must fail locally against the exact allocation budget.
Merged manager #54 / executor f7f95a31 filters zero-budget concrete-recipient nodes before both internal and external matching. When GenVM receives a zero-remaining exact node, its internal path can use the wildcard and emit a message for which consensus selects the exact node and rejects at reveal. This is verified in the executor tests; the composed Node path is tracked separately. The existing external zero-budget fallback remains intentional. Before #54, executor 16b81732 had no zero-budget filter and already tested that an exhausted exact key stays selected.
This is an expected-red, test-only handoff. It does not change production matching.
Reproduction and validation
The executor commit updates three existing tests in
executor/src/wasi/genlayer_sdk/tests.rsto assert the current consensus rule:internal_zero_remaining_exact_shadows_funded_wildcard: red; actual wildcard index 0, expected exact index 1.internal_zero_remaining_exact_phase_blocks_wildcard: red; actual wildcard match bypasses the exact key's phase mismatch.internal_zero_remaining_exact_fails_before_using_wildcard: red; call/deploy emits successfully where an internal allocation-budget error is expected.At manager 619dfad / executor f7f95a31,
cargo test --manifest-path executor/Cargo.toml --libproduced 152 passed, 3 failed, all three failures above. Both external zero-budget controls passed.cargo fmt --all -- --checkand the stack-relative diff check passed. The exact executor binary built locally. The manager binary did not build on this macOS host becauselua53.pcis unavailable; the repository Nix shells request Linux glibc.Acceptance for implementation
No full E2E is requested for this expected-red draft.