Skip to content

Improve follow-up environment story coverage - #2530

Open
brsbl wants to merge 4 commits into
bb/lower-composer-control-emphasis-thr_sjdd7gudiqfrom
bb/improve-follow-up-environment-stories-thr_sjdd7gudiq
Open

Improve follow-up environment story coverage#2530
brsbl wants to merge 4 commits into
bb/lower-composer-control-emphasis-thr_sjdd7gudiqfrom
bb/improve-follow-up-environment-stories-thr_sjdd7gudiq

Conversation

@brsbl

@brsbl brsbl commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

What was wrong

The follow-up composer story catalog defaulted every row without an explicit environment fixture to the same local-direct summary, so most functional states repeated one environment treatment. The environment matrix also omitted unmanaged, named, and detached worktree shapes, and its detached fixture lacked the machine label needed to render the worktree icon.

What changed

  • Rotates the functional overview through a balanced mix of local/remote and direct/worktree summaries.
  • Expands Environment matrix with unmanaged, named, and detached worktree rows.
  • Supplies the detached fixture's machine label so the production FolderGit environment icon renders.
  • Keeps provisioning on bb’s active-work Loading03 indicator because discovery has not confirmed the eventual workspace type.
  • Changes only Ladle fixtures; there are no product, daemon-wire, SDK, API, CLI, or persistence changes.

How you verified

  • Exact rebased head f4707e0ad2ea6622fa4c314e943c6735a1d21f34 passes every required GitHub check, including all app shards, packages, server, integration, and Linux/macOS package smoke.
  • Ladle metadata registers both the native-skill-call and environment-matrix stories; neither renders a missing-story state.
  • Chrome for Testing 152.0.7977.64 rendered the exact parent and child matrix at the same 1440×900 viewport and scroll position. The child visibly adds unmanaged, named, and detached worktree rows with the production worktree icon; provisioning uses bb’s active-work Loading03 indicator. The deliberate QA pass also verified all environment accessible labels, a balanced overview mix, no horizontal overflow, and no runtime exceptions.
  • Safari is not required for this non-marketing Ladle change.

Before — parent head 699352c7e7576ee937d68d3e9f43f02f570aecfd

The matrix ends after managed local/remote worktrees.

Before — environment matrix without unmanaged, named, or detached worktrees

After — child head f4707e0ad2ea6622fa4c314e943c6735a1d21f34

The same fixture now exposes unmanaged, named, and detached worktree label/icon shapes.

After — expanded environment matrix with unmanaged, named, and detached worktrees

BB-Thread-ID: thr_sjdd7gudiq

AGENT GENERATED

@brsbl
brsbl force-pushed the bb/improve-follow-up-environment-stories-thr_sjdd7gudiq branch from 5ac2100 to c467235 Compare August 28, 2026 00:06
@brsbl
brsbl force-pushed the bb/improve-follow-up-environment-stories-thr_sjdd7gudiq branch from c467235 to f4707e0 Compare August 28, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant