Ci linting action

[psg-19]

Description and Notes

Closes #677
Currently, typos runs inside the Rust CI linting job in rust.yml, even though it's language agnostic and checks the entire project not just rust code. Similarly, Python linting is duplicated in functional.yml.

This PR creates a dedicated lint.yml workflow that separates language agnostic linting from rust specific check.

How to verify the changes you have done?

the ci passes in my fork https://github.com/psg-19/Floresta/actions

Contributor Checklist

• I've followed the contribution guidelines
• I've verified one of the following:
  • Ran just pcc (recommended but slower)
  • Ran just lint-features '-- -D warnings' && cargo test --release
  • Confirmed CI passed on my fork
• I've linked any related issue(s) in the sections above

[moisesPompilio]

I think there are still some issues to be addressed in the issue for this PR to be considered as fully resolving it.

[psg-19]

I think there are still some issues to be addressed in the issue for this PR to be considered as fully resolving it.

Okay, I'll be reading the discussions actively and change the code accordingly.

[moisesPompilio]

Please leave this PR as a draft for now

[Davidson-Souza]

My understanding of the issue is that this should also be under lint.yml, right @jaoleal?

[Vedd-Patel]

renaming the rust job id from linting to rust-lint may break required status checks?
unless branch protection is updated?? am i right?

[psg-19]

My understanding of the issue is that this should also be under lint.yml, right @jaoleal?

So is it like this, we should move all linting stuff like typos, clippy, cargo fmt, cargo doc, Python lint to lint.yml and rust.yml only for testing and building

[jaoleal]

My understanding of the issue is that this should also be under lint.yml, right @jaoleal?

Yes, Ideally a centralized job for linting

[jaoleal]

Almost it, move the rust linting to lint.yml and could you also address #730 ? (Never mind, The diff would be huge and i prefer for someone of the team to address that.)

[jaoleal]

My understanding of the issue is that this should also be under lint.yml, right @jaoleal?

Yes, Ideally a centralized job for linting

[psg-19]

Almost it, move the rust linting to lint.yml and could you also address #730 ? (Never mind, The diff would be huge and i prefer for someone of the team to address that.)

Done, moved rust linting to the new lint.yml file

[csgui]

This PR is ready for review or is it a draft?

[jaoleal]

HI, @psg-19 appears to be almost there, only thing missing is the commit. I think this can be merged in a single commit,

For reference: https://github.com/getfloresta/Floresta/blob/master/CONTRIBUTING.md#commits

[psg-19]

HI, @psg-19 appears to be almost there, only thing missing is the commit. I think this can be merged in a single commit,

For reference: https://github.com/getfloresta/Floresta/blob/master/CONTRIBUTING.md#commits

Sure, will squash the commits to one commit and rebase

[jaoleal]

e1b7432 is almost there, just remind that the reference ive sent to you also included instructions about how to write commit messages, as it is the commit will not pass CI.

[psg-19]

e1b7432 is almost there, just remind that the reference ive sent to you also included instructions about how to write commit messages, as it is the commit will not pass CI.

Yeah, missed to fix the commit message. Did that now.

[jaoleal]

For the commit message, prefer

"ci: centralize lint jobs on lint.yml"

Also, would be nice for it to explain a little about the job, but the tittle is meaningfull enough

[jaoleal]

ACK de5c851

[Vedd-Patel]

ACK de5c851
only merge conflicts should be resolved
but one optional thing i've thought of is to add paths filters so heavy workflows don’t run on unrelated file changes

[jaoleal]

but one optional thing i've thought of is to add paths filters so heavy workflows don’t run on unrelated file changes

We can work on this on #960

[moisesPompilio]

Need rebase