Chore: add linters and formatters para Dockerfile, justfile, TOMLs and sh scripts.#960
Draft
jaoleal wants to merge 6 commits into
Draft
Chore: add linters and formatters para Dockerfile, justfile, TOMLs and sh scripts.#960jaoleal wants to merge 6 commits into
jaoleal wants to merge 6 commits into
Conversation
… CI behavior. The justfile contained separate recipes for checking on format and to actively format, since new languages were added so was the necessity to use them in a standardized manner using proper lints, this stabilishes a new approach to formatting locally.
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
Fixes #730
Rebased on top of #924 which unifies the linting job, this pr introduces formatting and linting for other auxiliary files that we had around the codebase, the most cool one is taplo that help us to maintain the organization done back there in 53430b7
I decided to address #730 myself because, together with it I could address some things that bothered me on the justfile related to linting and formatting (8142948). Also its safer for such a "big" change to be made by a member of the team or a known contributor.
Each commit:
draft until i do a self-review
How to verify the changes you have done?
For those who have nix its easier to verify since it makes impossible to a formatter change to scape the commit that it were added.
To verify the changes i ran:
git rebase --exec "nix develop --command just lint" upstream/master
For a non nix environment a similar would be, just be sure to have the formatters available and exposed to just:
git rebase --exec "just lint" upstream/master