Skip to content

Chore: add linters and formatters para Dockerfile, justfile, TOMLs and sh scripts.#960

Draft
jaoleal wants to merge 6 commits into
getfloresta:masterfrom
jaoleal:peripheral_lint
Draft

Chore: add linters and formatters para Dockerfile, justfile, TOMLs and sh scripts.#960
jaoleal wants to merge 6 commits into
getfloresta:masterfrom
jaoleal:peripheral_lint

Conversation

@jaoleal
Copy link
Copy Markdown
Member

@jaoleal jaoleal commented Apr 15, 2026

Description and Notes

Fixes #730

Rebased on top of #924 which unifies the linting job, this pr introduces formatting and linting for other auxiliary files that we had around the codebase, the most cool one is taplo that help us to maintain the organization done back there in 53430b7

I decided to address #730 myself because, together with it I could address some things that bothered me on the justfile related to linting and formatting (8142948). Also its safer for such a "big" change to be made by a member of the team or a known contributor.

Each commit:

  • introduces a new linter and formatter for such a language/file
  • with a configuration file if needed (ex: taplo needs it)
  • include dependency on flake.nix so I can use it on my current dev setup.
  • CI job that checks it
  • The changes accross the database that such a linter/formatter applies.

draft until i do a self-review

How to verify the changes you have done?

For those who have nix its easier to verify since it makes impossible to a formatter change to scape the commit that it were added.

To verify the changes i ran:

git rebase --exec "nix develop --command just lint" upstream/master

For a non nix environment a similar would be, just be sure to have the formatters available and exposed to just:

git rebase --exec "just lint" upstream/master

psg-19 and others added 6 commits April 15, 2026 21:20
… CI behavior.

The justfile contained separate recipes for checking on format and to actively format, since new languages were added so was the necessity to use them in a standardized manner using proper lints, this stabilishes a new approach to formatting locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Check and Format peripheral code.

2 participants