test(packaging): give packed verification its own 120s budget - #46
Merged
Conversation
The verifier owns a 90-second timeout, but the packed verification ran under Vitest's default test budget and could be killed before the verifier terminated and reaped its child processes. Apply the shared 120s PACKAGING_TIMEOUT_MS to the packed verification test so the outer budget always outlives the inner one. Co-Authored-By: Kimchi <noreply@kimchi.dev>
Kimchi Code ReviewA review is being prepared and will be posted shortly.
What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifier owns a 90-second timeout, but the packed verification ran under Vitest's default test budget and could be killed before the verifier terminated and reaped its child processes. Apply the shared 120s PACKAGING_TIMEOUT_MS to the packed verification test so the outer budget always outlives the inner one.