Skip to content

test(packaging): give packed verification its own 120s budget #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmateusz merged 1 commit into from
Aug 26, 2026
Merged

test(packaging): give packed verification its own 120s budget #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/packaging.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import { scriptedAgent } from "./scripted-agent.ts"

const exec = promisify(execFile)
const repoRoot = path.resolve(import.meta.dirname, "..")
// Packing and packed verification cross real Node, pnpm, and Vitest process boundaries. The verifier
// owns a 90-second timeout, so its outer Vitest budget must leave time to terminate and reap children.
const PACKAGING_TIMEOUT_MS = 120_000

const pkg = JSON.parse(await readFile(path.join(repoRoot, "package.json"), "utf8")) as {
name: string
Expand Down Expand Up @@ -73,7 +76,7 @@ console.log(JSON.stringify(results))

const probed = await exec(process.execPath, [probe], { cwd: path.dirname(probe) })
results = new Map((JSON.parse(probed.stdout) as ProbeResult[]).map((r) => [r.specifier, r]))
}, 120_000)
}, PACKAGING_TIMEOUT_MS)

afterAll(async () => {
if (workDir) await rm(workDir, { recursive: true, force: true })
Expand Down Expand Up @@ -211,7 +214,9 @@ console.log(JSON.stringify(results))
expect(manifest.packageManager).toMatch(/^pnpm@/)
})

it("runs focused verification from the packed install", async () => {
it("runs focused verification from the packed install", verifyPackedWorkflow, PACKAGING_TIMEOUT_MS)

async function verifyPackedWorkflow() {
const projectRoot = path.join(workDir, "verification-project")
const workflowDirectory = path.join(projectRoot, ".kimchi/workflows")
const modules = path.join(workflowDirectory, "node_modules")
Expand Down Expand Up @@ -274,5 +279,5 @@ console.log(JSON.stringify(result))

const { stdout } = await exec(process.execPath, [verifierProbe], { cwd: path.dirname(verifierProbe) })
expect(JSON.parse(stdout)).toMatchObject({ files: 1, tests: 1, passedTests: 1 })
})
}
})
Loading