Repository navigation
fix(transcript): refuse every native edit the block does not handle - #1049
Conversation
…1038) The transcript's beforeinput guard prevented only delete* and insert*, so Ctrl/Cmd+B, I and U (formatBold/Italic/Underline) styled the words in the DOM behind transcript.words. The guard now prevents every input type, then routes delete* to the cut and insert* to the insertion field as before.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe transcript editor now prevents native ChangesTranscript input handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to Formatting shortcuts such as bold, italic and underline no longer alter the transcript DOM, which keeps it in sync with the transcript data. Delete and insert behavior is preserved. The change looks safe to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
beforeinputguard preventeddelete*andinsert*and let the rest through, so Ctrl/Cmd+B, I and U styled the words in the DOM whiletranscript.wordsstayed unchanged.delete*to the cut andinsert*to the insertion field. A future input type is covered too.handlePaste.Related issue
Closes #1038
Type of change
Release impact
Desktop impact
Testing
TranscriptPane.wordInsert.test.tsx:formatBold,formatItalic,formatUnderline,historyUndoandhistoryRedoare blocked; delete still cuts; insert still opens the field. The blocking tests fail without the fix.🤖 Generated with Claude Code
Summary by CodeRabbit