Skip to content

fix(chat): format every message time where it is drawn #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EtienneLescot merged 2 commits into from
Oct 13, 2026
Merged

fix(chat): format every message time where it is drawn #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d208c1
fix(chat): format every message time where it is drawn
EtienneLescot Oct 12, 2026
9ce63ac
fix(chat): show a stored time that is no date as stored
EtienneLescot Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/ai-edition/LeftPanel.copyMessage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,3 +249,15 @@ describe("ChatStripPanel Copy message (issue #738)", () => {
expect(toastError).not.toHaveBeenCalled();
});
});

describe("ChatStripPanel message time (#1134)", () => {
it("shows a stored message's time as a clock time, never as the raw ISO string", async () => {
stubClipboard(copyToClipboard);
const view = await renderPanelWithAssistantMessage();

// The main process stores every message with an ISO `createdAt`. A session loaded from it,
// like the one a first message creates, used to print that string as is.
expect(view.container.textContent).not.toContain("2026-09-23T00:00:01");
expect(view.getByText(new Date("2026-09-23T00:00:01Z").toLocaleTimeString())).toBeTruthy();
});
});
13 changes: 10 additions & 3 deletions src/components/ai-edition/LeftPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ interface ChatDisplayMessage {
id?: string;
role: string;
content: string;
/** ISO timestamp, as the main process stores it; formatted only where it is drawn (#1134). */
time?: string;
toolCalls?: AiEditionToolCallSummary[];
// ponytail: axcut parity — non-null on user messages that have a
Expand All @@ -46,6 +47,12 @@ interface ChatDisplayMessage {
thinking?: string;
}

/** A message's clock time; a stored value that is no date is shown as stored. */
function formatMessageTime(time: string): string {
const date = new Date(time);
return Number.isNaN(date.getTime()) ? time : date.toLocaleTimeString();
}

// Quick-access model picker anchored to the composer's model pill — mirrors
// axcut's LlmPopover in "models"/"providers" mode (a lightweight popover, not
// the full AI-settings modal). "Provider settings…" in the providers screen
Expand Down Expand Up @@ -601,7 +608,7 @@ export function ChatStripPanel() {
id: optimisticUserId,
role: "user",
content: text,
time: new Date().toLocaleTimeString(),
time: new Date().toISOString(),
checkpointId: optimisticUserId,
},
]);
Expand Down Expand Up @@ -672,7 +679,7 @@ export function ChatStripPanel() {
{
role: "assistant",
content: assistant.content,
time: new Date().toLocaleTimeString(),
time: new Date().toISOString(),
toolCalls: assistant.toolCalls,
// ponytail: snapshot the live reasoning trace onto the
// finished message so it can be revisited (collapsed by
Expand Down Expand Up @@ -1263,7 +1270,7 @@ export function ChatStripPanel() {
color: "var(--muted)",
}}
>
{m.time}
{formatMessageTime(m.time)}
</span>
) : null}
</div>
Expand Down
Loading