Feat/add gitlab variables controls - #422
Open
Joseph94m wants to merge 2 commits into
Open
Conversation
Joseph94m
force-pushed
the
feat/add-gitlab-variables-controls
branch
from
August 20, 2026 07:17
a7c469b to
8ff046b
Compare
Joseph94m
marked this pull request as ready for review
August 20, 2026 07:52
Joseph94m
requested review from
Totara-thib,
coconux3 and
thomasboni
as code owners
August 20, 2026 07:52
Joseph94m
force-pushed
the
feat/add-gitlab-variables-controls
branch
from
August 20, 2026 08:17
8ff046b to
4c9e23c
Compare
Joseph94m
force-pushed
the
feat/add-gitlab-variables-controls
branch
from
August 20, 2026 08:42
4c9e23c to
3aac977
Compare
Joseph94m
force-pushed
the
feat/add-gitlab-variables-controls
branch
from
August 20, 2026 09:04
3aac977 to
bfdd4eb
Compare
Contributor
|
@Joseph94m Reviewed + tested e2e by Claude, then I verified its results: What works
Blockers
Nits (should be done too)
|
Joseph94m
force-pushed
the
feat/add-gitlab-variables-controls
branch
from
August 21, 2026 14:40
bfdd4eb to
334d820
Compare
Collaborator
Author
|
@thomasboni should be better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #412
Closes #418
Test on https://gitlab.com/getplumber/examples/go-test-with-hash @thomasboni