Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion javascript/sentry-conventions/src/attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24246,7 +24246,13 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
isInOtel: true,
visibility: 'public',
example: ['Users', 'Cats'],
changelog: [{ version: '0.16.0', prs: [479], description: 'Added aws.dynamodb.table_names attribute' }],
changelog: [
{ version: 'next', description: 'Added additional context on sorting the names' },
{ version: '0.16.0', prs: [479], description: 'Added aws.dynamodb.table_names attribute' },
],
additionalContext: [
'List each table name once, sorted alphabetically, so the same call gets the same value and span description (`DynamoDB.BatchGetItem Cat, Users`), whatever the order of the tables in the request.',
],
},
'aws.dynamodb.total_segments': {
brief: 'The value of the `TotalSegments` request parameter.',
Expand Down
7 changes: 7 additions & 0 deletions model/attributes/aws/aws__dynamodb__table_names.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"key": "aws.dynamodb.table_names",
"brief": "The keys in the `RequestItems` object field.",
"additional_context": [
"List each table name once, sorted alphabetically, so the same call gets the same value and span description (`DynamoDB.BatchGetItem Cat, Users`), whatever the order of the tables in the request."
],
"type": "string[]",
"apply_scrubbing": {
"key": "manual"
Expand All @@ -9,6 +12,10 @@
"example": ["Users", "Cats"],
"visibility": "public",
"changelog": [
{
"version": "next",
"description": "Added additional context on sorting the names"
},
{
"version": "0.16.0",
"prs": [479],
Expand Down
15 changes: 13 additions & 2 deletions model/description/db.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,19 @@
"db.redis",
"redis"
],
"templates": ["{{db.query.text}}"],
"examples": ["SELECT * FROM users WHERE id = ?"]
"templates": [
"{{db.query.text}}",
"{{rpc.service}}.{{rpc.method}} {{aws.dynamodb.table_names}}.{{aws.dynamodb.index_name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.dynamodb.table_names}}",
"{{rpc.service}}.{{rpc.method}}"
Comment thread
pabloDeputter marked this conversation as resolved.
],
"examples": [
"SELECT * FROM users WHERE id = ?",
"DynamoDB.Query orders.by-status",
"DynamoDB.GetItem orders",
"DynamoDB.BatchGetItem customers, orders",
"DynamoDB.ListTables"
]
}
]
}
8 changes: 6 additions & 2 deletions model/description/messaging.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@
"queue.task.huey",
"queue.task.rq"
],
"templates": ["{{messaging.destination.name}}"],
"examples": ["order-events"]
"templates": [
"{{rpc.service}}.{{rpc.method}} {{messaging.destination.name}}",
"{{messaging.destination.name}}",
"{{rpc.service}}.{{rpc.method}}"
],
"examples": ["SQS.SendMessageBatch orders", "SNS.Publish alerts", "order-events", "SQS.ReceiveMessage"]
}
]
}
30 changes: 30 additions & 0 deletions model/description/rpc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"brief": "RPC",
"operations": [
{
"name": "RPC call",
"brief": "A remote procedure call, such as an AWS SDK call or a gRPC call.",
"ops": ["rpc"],
"templates": [
"{{rpc.service}}.{{rpc.method}} {{aws.s3.bucket}}",
"{{rpc.service}}.{{rpc.method}} {{faas.invoked_name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.lambda.target_function.name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.kinesis.stream_name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.step_functions.state_machine.name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.step_functions.activity.name}}",
"{{rpc.service}}.{{rpc.method}} {{aws.secretsmanager.secret.name}}",
"{{rpc.service}}.{{rpc.method}} {{messaging.destination.name}}",
"{{rpc.service}}.{{rpc.method}}"
],
"examples": [
"S3.GetBucketPolicy invoices",
"Lambda.UpdateFunctionCode billing",
"Kinesis.PutRecords clicks",
"SFN.StartExecution orders",
"SecretsManager.GetSecretValue db-password",
"SQS.ChangeMessageVisibility orders",
"S3.ListBuckets"
]
}
]
}
7 changes: 7 additions & 0 deletions python/src/sentry_conventions/attributes.py
Original file line number Diff line number Diff line change
Expand Up @@ -14284,12 +14284,19 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
visibility=Visibility.PUBLIC,
example=["Users", "Cats"],
changelog=[
ChangelogEntry(
version="next",
description="Added additional context on sorting the names",
),
ChangelogEntry(
version="0.16.0",
prs=[479],
description="Added aws.dynamodb.table_names attribute",
),
],
additional_context=[
"List each table name once, sorted alphabetically, so the same call gets the same value and span description (`DynamoDB.BatchGetItem Cat, Users`), whatever the order of the tables in the request."
],
),
"aws.dynamodb.total_segments": AttributeMetadata(
brief="The value of the `TotalSegments` request parameter.",
Expand Down
Loading