Repository navigation
feat(descriptions): Add descriptions for AWS SDK spans by service, operation and resource - #717
pabloDeputter wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b2f4cf. Configure here.
| "templates": [ | ||
| "{{rpc.service}}.{{rpc.method}} {{aws.s3.bucket}}", | ||
| "{{rpc.service}}.{{rpc.method}} {{faas.invoked_name}}", | ||
| "{{rpc.service}}.{{rpc.method}} {{aws.lambda.function.name}}", |
There was a problem hiding this comment.
Lambda name attribute is shadowed
Medium Severity
faas.invoked_name is listed ahead of aws.lambda.function.name. Lambda calls that take FunctionName carry both the raw parameter, often a qualified name or ARN, and the normalized function name. The first complete template wins, so the normalized name never becomes the span description.
Reviewed by Cursor Bugbot for commit 5b2f4cf. Configure here.
| "{{db.query.text}}", | ||
| "{{rpc.service}}.{{rpc.method}} {{aws.dynamodb.table_names}}.{{aws.dynamodb.index_name}}", | ||
| "{{rpc.service}}.{{rpc.method}} {{aws.dynamodb.table_names}}", | ||
| "{{rpc.service}}.{{rpc.method}}" |
There was a problem hiding this comment.
DynamoDB descriptions drop table names
Medium Severity
GetItem and Query spans keep the table on db.collection.name, while aws.dynamodb.table_names is defined as the keys of RequestItems. Those calls miss the table templates and match rpc.service plus rpc.method, so the description is DynamoDB.GetItem and replaces the name fallback that included the table.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5b2f4cf. Configure here.
This branch was successfully deployed
1 participant
Description
Adds description templates so it follows the same format like the
object.*descriptions in #707:<Service>.<Operation> <resource>.rpcLambda.Invoke)Lambda.Invoke billing,SecretsManager.GetSecretValue db-password,SQS.ChangeMessageVisibility orders;S3.ListBuckets(operations with no resource)db(DynamoDB, nodb.query.text)GetItem orders)DynamoDB.GetItem orders,DynamoDB.Query orders.by-status,DynamoDB.BatchGetItem customers, orders,DynamoDB.ListTablesqueue.*(SQS, SNS)ordersSQS.SendMessageBatch orders,SNS.Publish alertsOnly AWS SDK spans have
rpc.serviceandrpc.method, so otherrpc,dband messaging spans are unaffected;dbspans that contain thedb.query.textattribute keep it as as their description.