Skip to content

fix(core): Enforce linked error limits for aggregate and suppressed errors - #25873

Merged
msonnb merged 1 commit into
developfrom
ms/linked-errors-limit
Oct 29, 2026
Merged

msonnb merged 1 commit into
developfrom
ms/linked-errors-limit

Conversation

@msonnb

@msonnb msonnb commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

This fixes a bug where AggregateError or SuppressedError children did not respect the linkedErrorsIntegration's maximum exception limit. By checking the limit before converting each child error to a Sentry exception, we enforce it for all three branches (regular errors chained via cause or another property, aggregate errors, and suppressed errors).

Closes #25836

…rrors

Co-Authored-By: OpenAI Codex <codex@openai.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 334b5af (PR test merge using develop at c521633)

Against: c521633 (develop) · base run #64105

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.41 kB +0.04% +10 B 🔺
@sentry/browser - with treeshaking flags 28.51 kB +0.03% +7 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 28.41 kB +0.04% +9 B 🔺
@sentry/browser (incl. Tracing) 52.67 kB +0.03% +12 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.68 kB +0.03% +12 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.6 kB +0.03% +12 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.9 kB +0.02% +10 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.51 kB +0.01% +8 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.64 kB +0.02% +10 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.61 kB +0.01% +11 B 🔺
@sentry/browser (incl. Feedback) 47.95 kB +0.02% +8 B 🔺
@sentry/browser (incl. sendFeedback) 35.48 kB +0.04% +11 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.58 kB +0.03% +9 B 🔺
@sentry/browser (incl. Metrics) 31.41 kB +0.04% +10 B 🔺
@sentry/browser (incl. Logs) 31.69 kB +0.03% +9 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.37 kB +0.04% +10 B 🔺
@sentry/react 32.2 kB +0.03% +7 B 🔺
@sentry/react (incl. Tracing) 54.95 kB +0.02% +8 B 🔺
@sentry/vue 38.68 kB +0.03% +9 B 🔺
@sentry/vue (incl. Tracing) 55.56 kB +0.02% +11 B 🔺
@sentry/svelte 30.43 kB +0.03% +9 B 🔺
@sentry/remix (Remix 3 client bundle) 57.72 kB +0.02% +10 B 🔺
CDN Bundle 32.12 kB +0.04% +11 B 🔺
CDN Bundle (incl. Tracing) 53.15 kB +0.03% +12 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.32 kB +0.04% +12 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 55.1 kB +0.02% +11 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 75.77 kB +0.02% +10 B 🔺
CDN Bundle (incl. Tracing, Replay) 91.31 kB +0.02% +12 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.27 kB +0.02% +10 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 97.44 kB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.45 kB +0.02% +12 B 🔺
CDN Bundle - uncompressed 94.5 kB +0.03% +28 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 157.49 kB +0.02% +28 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.05 kB +0.03% +28 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.46 kB +0.02% +28 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.6 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 279.18 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.13 kB +0.01% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 292.88 kB +0.01% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 298.82 kB +0.01% +28 B 🔺
@sentry/nextjs (client) 57.8 kB +0.02% +7 B 🔺
@sentry/sveltekit (client) 53.12 kB +0.02% +9 B 🔺
@sentry/core/server 44.34 kB - -
@sentry/core/browser 13.95 kB - -
@sentry/node 155.11 kB +0.02% +29 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.67 kB - -
@sentry/node - without tracing 95.86 kB +0.04% +33 B 🔺
@sentry/node - without channel injection 135.75 kB +0.03% +31 B 🔺
@sentry/aws-serverless 104.02 kB +0.04% +33 B 🔺
@sentry/cloudflare (withSentry) - minified 198.04 kB +0.02% +28 B 🔺
@sentry/cloudflare (withSentry) 491.9 kB +0.02% +72 B 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 218.62 kB +0.02% +28 B 🔺

View base workflow run

@msonnb

msonnb commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 2 not successful, 55 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry (latest) Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Failing after 4m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 46s Details
✅ CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 45s Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 45s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 35s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 24s Details
✅ CI: Optional E2E Tests / E2E node-eve Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 57s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 32s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 16s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 46s Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Successful in 37s Details
✅ CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) Successful in 18s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 16s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) Successful in 17s Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 46s Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Successful in 48s Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 52s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Successful in 41s Details
✅ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry Test (optional) Successful in 58s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 17s Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 55s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 1m Details

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0631150. Configure here.

@msonnb
msonnb marked this pull request as ready for review October 29, 2026 12:03
@msonnb
msonnb requested review from a team as code owners October 29, 2026 12:03
@msonnb
msonnb requested review from Lms24, andreiborza, logaretm, mydea and nicohrubec and removed request for a team October 29, 2026 12:03
@msonnb
msonnb merged commit 1e3ef41 into develop Oct 29, 2026
397 of 399 checks passed
@msonnb
msonnb deleted the ms/linked-errors-limit branch October 29, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linkedErrors limit is not applied to AggregateError / SuppressedError children

3 participants