Skip to content

fix(core): Enforce linked error limits for aggregate and suppressed errors #25873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msonnb merged 1 commit into from
Oct 29, 2026
Merged

fix(core): Enforce linked error limits for aggregate and suppressed errors #25873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/utils/aggregate-errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function aggregateExceptionsFromError(
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError
if (isExceptionGroup(error)) {
error.errors.forEach((childError, i) => {
if (isError(childError)) {
if (newExceptions.length < limit + 1 && isError(childError)) {
applyExceptionGroupFieldsForParentException(exception, exceptionId, error);
const newException = exceptionFromErrorImplementation(parser, childError);
const newExceptionId = newExceptions.length;
Expand All @@ -102,7 +102,7 @@ function aggregateExceptionsFromError(
if (isSuppressedError(error)) {
['error', 'suppressed'].forEach(property => {
const childError = error[property];
if (isError(childError)) {
if (newExceptions.length < limit + 1 && isError(childError)) {
applyExceptionGroupFieldsForParentException(exception, exceptionId, error);
const newException = exceptionFromErrorImplementation(parser, childError);
const newExceptionId = newExceptions.length;
Expand Down
44 changes: 44 additions & 0 deletions packages/core/test/lib/utils/aggregate-errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,50 @@ describe('applyAggregateErrorsToEvent()', () => {
});
});

test('limits AggregateError children', () => {
const error = new FakeAggregateError(
Array.from({ length: 20 }, (_, i) => new Error(`child-${i}`)),
'group',
);
const event: Event = { exception: { values: [exceptionFromError(stackParser, error)] } };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 5, event, { originalException: error });

expect(event.exception?.values?.map(exception => exception.value)).toEqual([
'child-4',
'child-3',
'child-2',
'child-1',
'child-0',
'group',
]);
});

test('limits SuppressedError siblings after traversing a nested error', () => {
const inner = new FakeSuppressedError(new Error('dispose failed'), new Error('original'), 'inner');
const error = new FakeSuppressedError(inner, new Error('outer suppressed'), 'outer');
const event: Event = { exception: { values: [exceptionFromError(stackParser, error)] } };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 2, event, { originalException: error });

expect(event.exception?.values?.map(exception => exception.value)).toEqual(['dispose failed', 'inner', 'outer']);
});

test('shares the limit across causes, SuppressedErrors, and AggregateErrors', () => {
const cause = new FakeSuppressedError(new Error('dispose failed'), new Error('original'), 'cause');
const error = new CustomAggregateError([new Error('child')], 'group', cause);
const event: Event = { exception: { values: [exceptionFromError(stackParser, error)] } };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 3, event, { originalException: error });

expect(event.exception?.values?.map(exception => exception.value)).toEqual([
'original',
'dispose failed',
'cause',
'group',
]);
});

test('should keep the original mechanism type for the root exception', () => {
const fakeAggregateError = new FakeAggregateError(
[new Error('Nested Error 1'), new Error('Nested Error 2')],
Expand Down
Loading