Raise MSRV to Rust 1.80#6105
Closed
ErichDonGubler wants to merge 11 commits into
Closed
Conversation
5b300f7 to
13db95e
Compare
Member
Author
|
Heeey, we're finally running into the same annoying errors here that I wasn't sure what to do with locally when I saw them: ☝🏻 @cwfitzgerald, @Wumpf: Not sure how to best proceed here, but I haven't given it many brain cycles, either. Will dedicate more in the absence of feedback in the next day or so. |
3aa12e9 to
b5973ab
Compare
Merged
a7cfba6 to
4e2f6ce
Compare
Member
Author
|
Leaving this as a draft until we actually have the option to upgrade to Rust 1.80. We might be able to hoist the upgrade to |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4e2f6ce to
c229479
Compare
6 tasks
b8278cb to
0adf9c8
Compare
kornelski
reviewed
Aug 28, 2024
6 tasks
c7e6991 to
16f5d35
Compare
e43fe55 to
85229ca
Compare
7088d8d to
313cf42
Compare
af32362 to
1bcf90d
Compare
8477e0f to
4144908
Compare
e7e868c to
a56abd7
Compare
This was previously an `allow`-by-default warning in Clippy's `pedantic` group, but with Rust 1.83 it was promoted to a `warn`-by-default member of its `complexity` group.
Consumes [`cfg_aliases`#8](katharostech/cfg_aliases#8) to eliminate warnings from `rustc`.
This resolves remaining outstanding cases that offend [`--check-cfg` in Rust 1.80](https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values) in `wgpu-core`.
…ck-cfg` in `wgpu_{hal,types}`
`std::mem::{size,align}_of{,_val}` was added to `std::prelude` in Rust
1.80; see
[`rust`#123168](rust-lang/rust#123168).
Weaken our dependence on the `once_cell` crate by using functionality from `std` instead that was upstreamed from `once_cell`, this time with what's available in Rust 1.80+. It's not yet possible to eliminate this dependency entirely, but do what we can for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Preemptunused_qualificationslints triggered in Rust 1.80 #6147.Depends on Yet more preempting of Rust 1.80 lints #6180.