Yet more preempting of Rust 1.80 lints#6180
Merged
ErichDonGubler merged 3 commits intoSep 3, 2024
Merged
Conversation
b3b3a34 to
1ee0bfe
Compare
Member
|
What's the problem this is solving? |
c2e564a to
48eb02b
Compare
Member
Author
Individual motivations are already in the OP and individual commits, but to summarize: most of this changes code to add |
9a31b72 to
54f8bb0
Compare
nical
approved these changes
Sep 3, 2024
As before, this is to minimize diffs. with Rust 1.80.
54f8bb0 to
12609ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Offloading some diff. complexity from #6105.
Description
Fixes more lints that will definitely affect us with Rust upgrades later.
Testing
Things still compile, so woot!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toNot necessary.CHANGELOG.md. See simple instructions inside file.